Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoding support #85

Closed
wants to merge 1 commit into from
Closed

encoding support #85

wants to merge 1 commit into from

Conversation

rlidwka
Copy link

@rlidwka rlidwka commented Apr 17, 2012

Some silly irc servers doesnt support UTF-8 but other encodings (cp1251 in my case). So it would be nice to add support for them.

Currently node-irc works with utf8 only and there is no way to use another encoding here.

@martynsmith
Copy link
Owner

Can you please put this into the documentation too as part of your patch?

If so, then I'll happily merge this :-)

Thanks,

@hatashiro
Copy link

Hi, @martynsmith !

I'm using node-irc with the web-based irc client project, subway: https://github.com/thedjpetersen/subway
We need encoding support and i personally forked node-irc and serve it with this patch to subway package.json.
But I'd like to finish serving and want subway to get node-irc from here directly.

What kind of document is needed? You replied rlldwka 6 months ago and no answer.
If possible, I can prepare the document for you.
I really hope this patch to be accepted.

regards.

@martynsmith
Copy link
Owner

Well, the patch doesn't merge cleanly any more either.

You need to find someone that can rebase the patch on to the current master branch, and then add documentation to API.rst for it.

If I find time, I'll do this for you, but if you can (or know someone who can) do it, that'd be awesome :-)

@martynsmith
Copy link
Owner

We can continue any discussion in pull request #113 :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants