encoding support with documentation #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great. Just a quick thought, do you think it'd be better to decode the buffer after all the chunks have been received (then you could get rid of that comment about potential bugs on multi-byte characters spanning chunks). It seems like it'd be fairly easy to do. Either way, If I don't hear back from you I'll merge this :-) |
|
Thank you for the reply. Regards. |
|
I commited a patch to decode the buffer after all the chunks've been received. Plz check the patch, and if there's something wrong, let me know. Thanks! Regards. |
Rebased and documented by @noraesae
Prevent bugs that can occur when decode the large chunk with multibyte encoding.
|
ping |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
I rebased and documented the pull request #85.
Please check the patch and documentation,
and if there's something wrong or i can do further, please let me know.
Thanks!
Regards.