Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify image arch's to build #348

Merged
merged 2 commits into from
Aug 19, 2022
Merged

Specify image arch's to build #348

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
73bd9e1
Specify image arch's to build
lryanuk Jul 26, 2022
bd9b0fb
add builder
lryanuk Aug 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/publish-image.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ jobs:
uses: docker/build-push-action@ad44023a93711e3deb337508980b4b5e9bcdc5dc
with:
context: .
platforms: linux/amd64,linux/arm64
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm pretty certain this will also require

 -
        name: Set up QEMU
        uses: docker/setup-qemu-action@v2
-
        name: Set up Docker Buildx
        uses: docker/setup-buildx-action@v2

Can you please also do a test run of the pipeline in your repository and link to the successful result?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the parts I missed, here's the successful build: https://github.com/lryanuk/chiadog/actions/runs/2883959326

Ran the container on a Raspberry Pi4, seems to be working as expected

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's great, thanks! 🙌

push: true
tags: ${{ steps.meta.outputs.tags }}
labels: ${{ steps.meta.outputs.labels }}