Specify image arch's to build #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Specify image arch's to include support for linux/arm64
martomi
requested changes
Jul 30, 2022
| @@ -36,6 +36,7 @@ jobs: | |||
| uses: docker/build-push-action@ad44023a93711e3deb337508980b4b5e9bcdc5dc | |||
| with: | |||
| context: . | |||
| platforms: linux/amd64,linux/arm64 | |||
There was a problem hiding this comment.
I'm pretty certain this will also require
-
name: Set up QEMU
uses: docker/setup-qemu-action@v2
-
name: Set up Docker Buildx
uses: docker/setup-buildx-action@v2
Can you please also do a test run of the pipeline in your repository and link to the successful result?
There was a problem hiding this comment.
Added the parts I missed, here's the successful build: https://github.com/lryanuk/chiadog/actions/runs/2883959326
Ran the container on a Raspberry Pi4, seems to be working as expected
martomi
approved these changes
Aug 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Specify image arch's to include support for linux/arm64
Added using example documented here: https://github.com/docker/build-push-action/blob/master/docs/advanced/multi-platform.md