Use modern language rules load statements #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martis42
force-pushed
the
use_modern_language_rules_load_statements
branch
2 times, most recently
from
9e69657 to
e310f5d
Compare
We upgrade to 0.15.0 due to: - we intend to use load statements which are available starting with 0.10.0. - versions 0.10.0 - 0.13.0 are not compatible to Bazel 6 - version 0.14.0 removed the still used `cc_proto_library` symbol - version 0.15.0 restored `cc_proto_library` and is compatible to Bazel 6
Loading all public symbols from `<language>/defs.bzl` is a deprecated approach for language rules. More fine grained loading prevents Bazel analyzing things unrelated to what one actually is interested in. This impacts us, as only for the fine grained loading corresponding bzl_library targets exists we need for creating our documentation with stardoc.
martis42
force-pushed
the
use_modern_language_rules_load_statements
branch
from
e310f5d to
6085d9a
Compare
Loading all public symbols from `<language>/defs.bzl` is a deprecated approach for language rules. More fine grained loading prevents Bazel analyzing things unrelated to what one actually is interested in. We do this now to be consistent to how we use `rules_cc`.
martis42
force-pushed
the
use_modern_language_rules_load_statements
branch
from
6085d9a to
70781e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changes:
Updating minimum required version for
rules_ccto 0.15.0