refactor: Load rules_python content from proper locations

Loading all public symbols from `<language>/defs.bzl` is a deprecated approach for language rules. More fine grained loading prevents Bazel analyzing things unrelated to what one actually is interested in. We do this now to be consistent to how we use `rules_cc`.
martis42 · Dec 16, 2024 · 5ab007a · 5ab007a
1 parent f46cb90
commit 5ab007a
Show file tree

Hide file tree

Showing 9 changed files with 11 additions and 9 deletions.
diff --git a/scripts/BUILD b/scripts/BUILD
@@ -1,4 +1,4 @@
-load("@rules_python//python:defs.bzl", "py_binary")
+load("@rules_python//python:py_binary.bzl", "py_binary")
 
 py_binary(
     name = "extract_std_headers",

diff --git a/scripts/test/BUILD b/scripts/test/BUILD
@@ -1,4 +1,4 @@
-load("@rules_python//python:defs.bzl", "py_test")
+load("@rules_python//python:py_test.bzl", "py_test")
 
 py_test(
     name = "extract_std_headers_test",

diff --git a/src/analyze_includes/BUILD b/src/analyze_includes/BUILD
@@ -1,4 +1,5 @@
-load("@rules_python//python:defs.bzl", "py_binary", "py_library")
+load("@rules_python//python:py_binary.bzl", "py_binary")
+load("@rules_python//python:py_library.bzl", "py_library")
 
 py_library(
     name = "lib",

diff --git a/src/analyze_includes/test/BUILD b/src/analyze_includes/test/BUILD
@@ -1,4 +1,4 @@
-load("@rules_python//python:defs.bzl", "py_test")
+load("@rules_python//python:py_test.bzl", "py_test")
 
 py_test(
     name = "evaluate_includes_test",

diff --git a/src/apply_fixes/BUILD b/src/apply_fixes/BUILD
@@ -1,4 +1,5 @@
-load("@rules_python//python:defs.bzl", "py_binary", "py_library")
+load("@rules_python//python:py_binary.bzl", "py_binary")
+load("@rules_python//python:py_library.bzl", "py_library")
 
 py_library(
     name = "lib",

diff --git a/src/apply_fixes/test/BUILD b/src/apply_fixes/test/BUILD
@@ -1,4 +1,4 @@
-load("@rules_python//python:defs.bzl", "py_test")
+load("@rules_python//python:py_test.bzl", "py_test")
 
 py_test(
     name = "bazel_query_test",

diff --git a/src/aspect/BUILD b/src/aspect/BUILD
@@ -1,5 +1,5 @@
 load("@bazel_skylib//:bzl_library.bzl", "bzl_library")
-load("@rules_python//python:defs.bzl", "py_binary")
+load("@rules_python//python:py_binary.bzl", "py_binary")
 
 py_binary(
     name = "process_target",

diff --git a/test/aspect/tree_artifact/BUILD b/test/aspect/tree_artifact/BUILD
@@ -1,4 +1,4 @@
-load("@rules_python//python:defs.bzl", "py_binary")
+load("@rules_python//python:py_binary.bzl", "py_binary")
 load(":create_tree_artifact.bzl", "create_tree_artifacts")
 
 py_binary(

diff --git a/third_party/pcpp/pcpp.BUILD b/third_party/pcpp/pcpp.BUILD
@@ -1,4 +1,4 @@
-load("@rules_python//python:defs.bzl", "py_library")
+load("@rules_python//python:py_library.bzl", "py_library")
 
 py_library(
     name = "pcpp",