[RFR] Fix missing query string after successful login

cypress/integration/auth.js

@@ -30,4 +30,21 @@ describe('Authentication', () => {
         ListPage.navigate();
         cy.url().then(url => expect(url).to.contain('/#/posts'));
     });
+
+    it('should redirect to initial url keeping query string', () => {
+        let urlBeforeLogout;
+
+        ListPage.navigate();
+        ListPage.addCommentableFilter();
+        cy.url().then(url => {
+            urlBeforeLogout = url;
+        });
+        ListPage.setAsNonLogged();
+        cy.reload();
+        LoginPage.login('login', 'password');
+        cy.url().then(urlAfterLogin => {
+            expect(urlAfterLogin).to.contain(urlBeforeLogout);
+        });
+        ListPage.commentableFilter().should('exist');
+    });
 });

cypress/support/ListPage.js

@@ -4,6 +4,7 @@ export default url => ({
         appLoader: '.app-loader',
         displayedRecords: '.displayed-records',
         filter: name => `.filter-field[data-source='${name}'] input`,
+        filterButton: name => `.filter-field[data-source='${name}']`,
         filterMenuItems: `.new-filter-item`,
         menuItems: `[role=menuitem]`,
         filterMenuItem: source => `.new-filter-item[data-key="${source}"]`,
@@ -63,6 +64,15 @@ export default url => ({
         return cy.get(this.elements.pageNumber(n)).click({ force: true });
     },
 
+    addCommentableFilter() {
+        this.openFilters();
+        cy.get(this.elements.filterMenuItem('commentable')).click();
+    },
+
+    commentableFilter() {
+        return cy.get(this.elements.filterButton('commentable'));
+    },
+
     setFilterValue(name, value, clearPreviousValue = true) {
         cy.get(this.elements.filter(name));
         if (clearPreviousValue) {
@@ -88,6 +98,12 @@ export default url => ({
         cy.get(this.elements.logout).click();
     },
 
+    setAsNonLogged() {
+        cy.window().then(win => {
+            win.localStorage.setItem('not_authenticated', true);
+        });
+    },
+
     toggleSelectAll() {
         cy.get(this.elements.selectAll).click();
     },

packages/ra-core/src/auth/Authenticated.spec.tsx

@@ -58,7 +58,10 @@ describe('<Authenticated>', () => {
                 type: 'RA/CLEAR_STATE',
             });
             expect(history.location.pathname).toEqual('/login');
-            expect(history.location.state).toEqual({ nextPathname: '/' });
+            expect(history.location.state).toEqual({
+                nextPathname: '/',
+                nextSearch: '',
+            });
         });
     });
 });

packages/ra-core/src/auth/useAuthenticated.spec.tsx

@@ -100,7 +100,10 @@ describe('useAuthenticated', () => {
                 type: 'RA/CLEAR_STATE',
             });
             expect(history.location.pathname).toEqual('/login');
-            expect(history.location.state).toEqual({ nextPathname: '/' });
+            expect(history.location.state).toEqual({
+                nextPathname: '/',
+                nextSearch: '',
+            });
         });
     });
 });

packages/ra-core/src/auth/useLogin.ts

@@ -35,18 +35,20 @@ const useLogin = (): Login => {
     const history = useHistory();
     const dispatch = useDispatch();
     const nextPathName = locationState && locationState.nextPathname;
+    const nextSearch = locationState && locationState.nextSearch;
 
     const login = useCallback(
         (params: any = {}, pathName) =>
             authProvider.login(params).then(ret => {
                 dispatch(resetNotification());
                 const redirectUrl = pathName
                     ? pathName
-                    : nextPathName || defaultAuthParams.afterLoginUrl;
+                    : nextPathName + nextSearch ||
+                      defaultAuthParams.afterLoginUrl;
                 history.push(redirectUrl);
                 return ret;
             }),
-        [authProvider, history, nextPathName, dispatch]
+        [authProvider, history, nextPathName, nextSearch, dispatch]
     );
 
     const loginWithoutProvider = useCallback(

packages/ra-core/src/auth/useLogout.ts

@@ -69,6 +69,7 @@ const useLogout = (): Logout => {
                 ) {
                     newLocation.state = {
                         nextPathname: history.location.pathname,
+                        nextSearch: history.location.search,
                     };
                 }
                 if (redirectToParts[1]) {

packages/ra-ui-materialui/src/input/AutocompleteArrayInput.tsx

@@ -206,7 +206,8 @@ const AutocompleteArrayInput = (props: AutocompleteArrayInputProps) => {
     });
 
     // eslint-disable-next-line
-    const debouncedSetFilter = useCallback(debounce(setFilter || DefaultSetFilter, debounceDelay),
+    const debouncedSetFilter = useCallback(
+        debounce(setFilter || DefaultSetFilter, debounceDelay),
         [setFilter, debounceDelay]
     );