Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFR] Fix missing query string after successful login #6129

Conversation

makbol
Copy link
Contributor

@makbol makbol commented Apr 6, 2021

I tested this solution with my existing project and it worked fine with custom login page and external identity provider. I hope this quick fix will be sufficient.

Fixes #6117

@makbol makbol force-pushed the bug/bug-6117-missing-query-params-after-successful-login branch from 4e6ffb7 to a239242 Compare April 6, 2021 13:47
Copy link
Collaborator

@djhi djhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some additional tests validating the search value would be nice.

@makbol
Copy link
Contributor Author

makbol commented Apr 12, 2021

@djhi Alright, I'll try. Can you give me some tips how I should approach testing that? From what I see you don't have functional tests set. My perspective is testing that would require passing from unlogged state through login process to redirect to app and check if query string stays. Maybe there's a simpler way of testing that?

@makbol
Copy link
Contributor Author

makbol commented Apr 12, 2021

Okay, functional test added. @djhi let me know if this is sufficient.

@makbol makbol requested a review from djhi April 12, 2021 12:51
@fzaninotto fzaninotto merged commit 44fbead into marmelab:master Apr 13, 2021
@fzaninotto
Copy link
Member

Thanks!

@fzaninotto fzaninotto added this to the 3.14.4 milestone Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Filter values, sort params etc are lost after successful logging-in in custom login page
3 participants