Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add helperText prop to ArrayInput #5078

Closed
wants to merge 2 commits into from
Closed

Conversation

netdown
Copy link

@netdown netdown commented Jul 23, 2020

Fixes #4227, follow-up of #4262. Typings are fixed in the latest react-final-form-arrays release, therefore tests should be fine now.

Copy link
Contributor

@Luwangel Luwangel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing 👍.
Please take a look at the failing test and maybe add a few ones.

@@ -42,7 +42,7 @@
"react": "^16.9.0",
"react-dom": "^16.9.0",
"react-final-form": "^6.5.0",
"react-final-form-arrays": "^3.1.1",
"react-final-form-arrays": "^3.1.2",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should run make install (which runs yarn install) in order to upgrade the yarn.lock file. It's the only way to really upgrade a dependency.

See Yarn documentation

@fzaninotto fzaninotto closed this Aug 11, 2020
@fzaninotto
Copy link
Member

Not sure why this got closed. I usually leave a comment when closing issues, so it must be a consequence of deleting the next branch during a minor release. Sorry for the bad signal.

Reopening. Please read the CI report and review and make the requested changes to have it merged.

@fzaninotto fzaninotto reopened this Nov 16, 2020
@fzaninotto fzaninotto closed this Dec 14, 2020
@fzaninotto fzaninotto deleted the branch marmelab:next December 14, 2020 08:40
@fzaninotto
Copy link
Member

This was closed automatically when I merged next to master - sorry for that. Reopening.

@fzaninotto fzaninotto reopened this Dec 14, 2020
@fzaninotto fzaninotto closed this Jan 30, 2021
@fzaninotto fzaninotto deleted the branch marmelab:next January 30, 2021 07:44
@fzaninotto
Copy link
Member

This was closed automatically when I merged next to master - sorry for that. Reopening.

@WiXSL
Copy link
Contributor

WiXSL commented Mar 20, 2021

This can be closed

@djhi
Copy link
Collaborator

djhi commented Mar 22, 2021

Superseded by #6062

@djhi djhi closed this Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants