-
-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add helperText prop to ArrayInput #5078
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for contributing 👍.
Please take a look at the failing test and maybe add a few ones.
@@ -42,7 +42,7 @@ | |||
"react": "^16.9.0", | |||
"react-dom": "^16.9.0", | |||
"react-final-form": "^6.5.0", | |||
"react-final-form-arrays": "^3.1.1", | |||
"react-final-form-arrays": "^3.1.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should run make install
(which runs yarn install
) in order to upgrade the yarn.lock
file. It's the only way to really upgrade a dependency.
Not sure why this got closed. I usually leave a comment when closing issues, so it must be a consequence of deleting the Reopening. Please read the CI report and review and make the requested changes to have it merged. |
This was closed automatically when I merged next to master - sorry for that. Reopening. |
This was closed automatically when I merged next to master - sorry for that. Reopening. |
This can be closed |
Superseded by #6062 |
Fixes #4227, follow-up of #4262. Typings are fixed in the latest react-final-form-arrays release, therefore tests should be fine now.