Add helperText prop to ArrayInput #4262
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests fail because of final-form/react-final-form-arrays#78. We cant merge this one until react-final-form-arrays fixes their bug upstream. |
archfz
reviewed
Apr 21, 2020
| <FieldTitle | ||
| label={label} | ||
| source={source} | ||
| resource={resource} | ||
| isRequired={isRequired(validate)} | ||
| /> | ||
| </InputLabel> | ||
| {(touched && error) || helperText ? ( |
There was a problem hiding this comment.
For consistency shouldn't this be under the items? For other inputs we don't put the helper text between the label and the form control. @fzaninotto what do you think ?
|
@fzaninotto What is the reason of closing? |
This has been fixed in version 3.1.2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4227
(port of #4236 in next branch)