Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for disabled prop in BooleanInput #4443

Merged
merged 1 commit into from
Feb 25, 2020
Merged

Add support for disabled prop in BooleanInput #4443

merged 1 commit into from
Feb 25, 2020

Conversation

JulienMattiussi
Copy link
Contributor

@JulienMattiussi JulienMattiussi commented Feb 24, 2020 •
edited
Loading

Closes #4424

Issue

Adding disabled property in BooleanInput component must disable it.
But this prop is ignored

Solution

Add disabled prop to BooleanInput

Screenshot

image

@JulienMattiussi JulienMattiussi added the WIP Work In Progress label Feb 24, 2020
@JulienMattiussi JulienMattiussi changed the base branch from master to next February 24, 2020 14:32
@JulienMattiussi JulienMattiussi changed the title Allow disabled on booleaninput Enhance : Allow disabled prop on BooleanInput Feb 24, 2020
@JulienMattiussi JulienMattiussi added RFR Ready For Review and removed WIP Work In Progress labels Feb 24, 2020
@fzaninotto fzaninotto changed the title Enhance : Allow disabled prop on BooleanInput Add support for disabled prop in BooleanInput Feb 25, 2020
@fzaninotto fzaninotto merged commit b80e536 into next Feb 25, 2020
@fzaninotto fzaninotto deleted the allow-disabled-on-booleaninput branch February 25, 2020 07:21
@fzaninotto fzaninotto added this to the 3.3.0 milestone Feb 25, 2020
@fzaninotto fzaninotto mentioned this pull request Feb 25, 2020
Closed
This was referenced Apr 10, 2020
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fzaninotto fzaninotto fzaninotto approved these changes

Assignees
No one assigned
Labels
RFR Ready For Review
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

Boolean Input should support disabled property
2 participants
@JulienMattiussi @fzaninotto