Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean Input should support disabled property #4424

Closed
mchaffotte opened this issue Feb 14, 2020 · 2 comments · Fixed by #4443
Closed

Boolean Input should support disabled property #4424

mchaffotte opened this issue Feb 14, 2020 · 2 comments · Fixed by #4443
Assignees

Comments

@mchaffotte
Copy link
Contributor

mchaffotte commented Feb 14, 2020

What you were expecting:
Adding disabled property in BooleanInput component must disable it.

What happened instead:
But this option is ignored

Steps to reproduce:
add this piece of code in your form: <BooleanInput disabled />

Environment

  • React-admin version: 3
@fzaninotto
Copy link
Member

It works if you pass disabled in the options: <BooleanInput options={{ disabled: true }} />. This is explained in the documentation:

image

However, I agree that it's counterintuitive as it's working in TextInput. I'm turning this issue to an enhancement request.

@fzaninotto fzaninotto changed the title Boolean Input does not support disabled property Boolean Input does should support disabled property Feb 19, 2020
@fzaninotto fzaninotto changed the title Boolean Input does should support disabled property Boolean Input should support disabled property Feb 19, 2020
@fzaninotto
Copy link
Member

Fixed by #4443

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants