Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the trimmed height/width by 1px #2

Merged
merged 1 commit into from
Nov 6, 2021
Merged

Increase the trimmed height/width by 1px #2

merged 1 commit into from
Nov 6, 2021

Conversation

pento
Copy link
Contributor

@pento pento commented Nov 6, 2021

trim() is based on this gist. There are a few comments on the gist noting that it takes an extra pixel off the right and bottom edges, this PR ports one of the suggested fixes for it.

Fixes #1.

@markus-wa
Copy link
Owner

amazing, thanks for the quick fix!

@markus-wa markus-wa added the bug Something isn't working label Nov 6, 2021
@markus-wa markus-wa merged commit b20a50d into markus-wa:main Nov 6, 2021
@pento
Copy link
Contributor Author

pento commented Nov 6, 2021

No problem, thank you for putting together this useful little library! 🙂

@markus-wa
Copy link
Owner

I have published v0.1.2 which should include your fix (skipping v0.1.1 as I had messed up something)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Images are trimmed a little too aggressively
2 participants