Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Images are trimmed a little too aggressively #1

Closed
pento opened this issue Nov 6, 2021 · 3 comments · Fixed by #2
Closed

Images are trimmed a little too aggressively #1

pento opened this issue Nov 6, 2021 · 3 comments · Fixed by #2
Labels
bug Something isn't working

Comments

@pento
Copy link
Contributor

pento commented Nov 6, 2021

This is a super neat little package, thanks for making it available! 🙂

Whilst testing it out, I noticed a bug where it seems like the trim is a little too aggressive, taking an extra row of pixels from the right/bottom. The behaviour becomes very noticeable when running stickerify twice on the same image.

Here's a demo where you can see the bug in action: https://codepen.io/pento/pen/NWvYpRe

@markus-wa
Copy link
Owner

Hi @pento - thanks for raising this!

Very cool idea actually to call it twice with a thick white outline followed by 1px black!

With just a quick look I couldn't spot the bug, so I'll try to delve into it a bit deeper soon (otherwise if you find what it is, PRs are very welcome 😄)

@markus-wa
Copy link
Owner

I will actually include a link to a codepen example based on yours as I think that shows the usage really well. Hope you don't mind 😄 (will credit you in the readme of course!)

@pento
Copy link
Contributor Author

pento commented Nov 6, 2021

Go for it, I hope folks find it useful! 🙂

@markus-wa markus-wa added the bug Something isn't working label Nov 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants