Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests/onAttach, onDomRefresh, onDomRemove, and precompiled template #3533

Merged
merged 1 commit into from
Nov 23, 2017
Merged

Tests/onAttach, onDomRefresh, onDomRemove, and precompiled template #3533

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 30 additions & 30 deletions test/unit/on-attach.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
import _ from 'underscore';
import View from '../../src/view';
import Region from '../../src/region';

describe('onAttach', function() {
const expectTriggerMethod = (method, target, retval, before = null) => {
expect(method)
Expand Down Expand Up @@ -37,13 +41,12 @@ describe('onAttach', function() {
});

let sinon;
let View;
let regionEl;
let TestView;
let region; // A Region to show our View within

beforeEach(function() {
sinon = this.sinon;
View = Marionette.View.extend(extendAttachMethods(Marionette.View)({
TestView = View.extend(extendAttachMethods(View)({
template: _.template('<header></header><main></main><footer></footer>'),
regions: {
header: 'header',
Expand All @@ -53,16 +56,16 @@ describe('onAttach', function() {
}));
// A Region to show our View within
this.setFixtures('<div id="region"></div>');
regionEl = document.getElementById('region');
region = new Marionette.Region({el: regionEl});
const regionEl = document.getElementById('region');
region = new Region({el: regionEl});
});

describe('when showing a view into a region of a view without events monitored', function() {
let layoutView;
let view;

beforeEach(function() {
const LayoutView = Marionette.View.extend({
const LayoutView = View.extend({
monitorViewEvents: false,
el: '#region',
template: _.template('<div id="child"></div>'),
Expand All @@ -74,7 +77,7 @@ describe('onAttach', function() {
layoutView = new LayoutView();
layoutView.render();

view = new View();
view = new TestView();
layoutView.showChildView('child', view);
});

Expand Down Expand Up @@ -120,8 +123,8 @@ describe('onAttach', function() {
let view;

beforeEach(function() {
view = new View();
detachedRegion = new Marionette.Region({el: document.createElement('div')});
view = new TestView();
detachedRegion = new Region({el: document.createElement('div')});
detachedRegion.show(view);
});

Expand All @@ -146,7 +149,7 @@ describe('onAttach', function() {
let view;

beforeEach(function() {
view = new View();
view = new TestView();
region.show(view);
});

Expand Down Expand Up @@ -193,21 +196,20 @@ describe('onAttach', function() {

describe('when the parent view is initially detached', function() {
describe('When showing a View with a single level of nested views', function() {
let parentView;
let mainView;
let footerView;

beforeEach(function() {
const ParentView = View.extend({
const ParentView = TestView.extend({
onRender: function() {
mainView = new View();
footerView = new View();
mainView = new TestView();
footerView = new TestView();
this.showChildView('main', mainView);
this.showChildView('footer', footerView);
}
});

parentView = new ParentView();
const parentView = new ParentView();
region.show(parentView);
});

Expand Down Expand Up @@ -239,21 +241,20 @@ describe('onAttach', function() {
});

describe('When showing a View with a single level of nested views in onAttach', function() {
let parentView;
let mainView;
let footerView;

beforeEach(function() {
const ParentView = View.extend({
const ParentView = TestView.extend({
onAttach: function() {
mainView = new View();
footerView = new View();
mainView = new TestView();
footerView = new TestView();
this.showChildView('main', mainView);
this.showChildView('footer', footerView);
}
});

parentView = new ParentView();
const parentView = new ParentView();
region.show(parentView);
});

Expand All @@ -274,16 +275,16 @@ describe('onAttach', function() {
let childView;

beforeEach(function() {
const GrandparentView = View.extend({
const GrandparentView = TestView.extend({
onRender: function() {
parentView = new ParentView();
this.showChildView('main', parentView);
}
});

const ParentView = View.extend({
const ParentView = TestView.extend({
onRender: function() {
childView = new View();
childView = new TestView();
this.showChildView('main', childView);
}
});
Expand Down Expand Up @@ -332,16 +333,15 @@ describe('onAttach', function() {

describe('when the parent view is initially attached', function() {
describe('When showing a View with a single level of nested views', function() {
let parentView;
let mainView;
let footerView;

beforeEach(function() {
parentView = new View();
const parentView = new TestView();
region.show(parentView);

mainView = new View();
footerView = new View();
mainView = new TestView();
footerView = new TestView();
parentView.showChildView('main', mainView);
parentView.showChildView('footer', footerView);
});
Expand All @@ -363,14 +363,14 @@ describe('onAttach', function() {
let childView;

beforeEach(function() {
const ParentView = View.extend({
const ParentView = TestView.extend({
onRender: function() {
childView = new View();
childView = new TestView();
this.showChildView('main', childView);
}
});

grandparentView = new View();
grandparentView = new TestView();
region.show(grandparentView);

parentView = new ParentView();
Expand Down
53 changes: 36 additions & 17 deletions test/unit/on-dom-refresh.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,61 +1,80 @@
import _ from 'underscore';
import Backbone from 'backbone';
import BackboneViewMixin from '../../src/mixins/backboneview';
import View from '../../src/view';
import Region from '../../src/region';

describe('onDomRefresh', function() {
'use strict';

let attachedRegion;
let detachedRegion;
let BbView;
let MnView;

beforeEach(function() {
this.setFixtures($('<div id="region"></div>'));
this.attachedRegion = new Marionette.Region({el: '#region'});
this.detachedRegion = new Marionette.Region({el: $('<div></div>')});
this.BbView = Backbone.View.extend({
attachedRegion = new Region({el: '#region'});
detachedRegion = new Region({el: $('<div></div>')});
BbView = Backbone.View.extend({
onDomRefresh: this.sinon.stub()
});
_.extend(this.BbView.prototype, Marionette.BackboneViewMixin);
this.MnView = Marionette.View.extend({
_.extend(BbView.prototype, BackboneViewMixin);
MnView = View.extend({
template: _.noop,
onDomRefresh: this.sinon.stub()
});
});

describe('when a Backbone view is shown detached from the DOM', function() {
let bbView;

beforeEach(function() {
this.bbView = new this.BbView();
this.detachedRegion.show(this.bbView);
bbView = new BbView();
detachedRegion.show(bbView);
});

it('should never trigger onDomRefresh', function() {
expect(this.bbView.onDomRefresh).not.to.have.been.calledOnce;
expect(bbView.onDomRefresh).not.to.have.been.calledOnce;
});
});

describe('when a Marionette view is shown detached from the DOM', function() {
let mnView;

beforeEach(function() {
this.mnView = new this.MnView();
this.detachedRegion.show(this.mnView);
mnView = new MnView();
detachedRegion.show(mnView);
});

it('should never trigger onDomRefresh', function() {
expect(this.mnView.onDomRefresh).not.to.have.been.calledOnce;
expect(mnView.onDomRefresh).not.to.have.been.calledOnce;
});
});

describe('when a Backbone view is shown attached to the DOM', function() {
let bbView;

beforeEach(function() {
this.bbView = new this.MnView();
this.attachedRegion.show(this.bbView);
bbView = new BbView();
attachedRegion.show(bbView);
});

it('should trigger onDomRefresh on the view', function() {
expect(this.bbView.onDomRefresh).to.have.been.calledOnce;
expect(bbView.onDomRefresh).to.have.been.calledOnce;
});
});

describe('when a Marionette view is shown attached to the DOM', function() {
let mnView;

beforeEach(function() {
this.mnView = new this.MnView();
this.attachedRegion.show(this.mnView);
mnView = new MnView();
attachedRegion.show(mnView);
});

it('should trigger onDomRefresh on the view', function() {
expect(this.mnView.onDomRefresh).to.have.been.calledOnce;
expect(mnView.onDomRefresh).to.have.been.calledOnce;
});
});

Expand Down
Loading