Tests/onAttach, onDomRefresh, onDomRemove, and precompiled template #3533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blikblum
requested changes
Nov 9, 2017
test/unit/on-attach.spec.js
Outdated
| let regionEl; | ||
| let region; // A Region to show our View within | ||
|
|
||
| beforeEach(function() { | ||
| sinon = this.sinon; | ||
| View = Marionette.View.extend(extendAttachMethods(Marionette.View)({ | ||
| testView = View.extend(extendAttachMethods(View)({ |
test/unit/on-dom-refresh.spec.js
Outdated
| beforeEach(function() { | ||
| this.bbView = new this.MnView(); | ||
| this.attachedRegion.show(this.bbView); | ||
| bbView = new MnView(); |
There was a problem hiding this comment.
Seems the test was already wrong. It should be new BbView
| this.View = Backbone.Marionette.View.extend({ | ||
| template: _.template(this.template) | ||
| template = 'foobar'; | ||
| testView = View.extend({ |
wesmangum
force-pushed
the
tests/onAttach-onDomRefresh-onDomRemove-templateRenderer
branch
from
f37d4da
to
b4ed1b7
Compare
blikblum
approved these changes
Nov 10, 2017
paulfalgout
reviewed
Nov 11, 2017
test/unit/on-dom-refresh.spec.js
Outdated
| @@ -1,61 +1,80 @@ | |||
| import _ from 'underscore'; | |||
| import Backbone from 'backbone'; | |||
| import Marionette from '../../src/backbone.marionette'; | |||
There was a problem hiding this comment.
we should be able to remove this import entirely
paulfalgout
reviewed
Nov 11, 2017
test/unit/on-dom-remove.spec.js
Outdated
| @@ -1,76 +1,95 @@ | |||
| import _ from 'underscore'; | |||
| import Backbone from 'backbone'; | |||
| import Marionette from '../../src/backbone.marionette'; | |||
wesmangum
force-pushed
the
tests/onAttach-onDomRefresh-onDomRemove-templateRenderer
branch
from
b4ed1b7
to
c33a923
Compare
paulfalgout
requested changes
Nov 16, 2017
test/unit/on-dom-remove.spec.js
Outdated
| beforeEach(function() { | ||
| this.bbView = new this.MnView(); | ||
| this.attachedRegion.show(this.bbView); | ||
| bbView = new MnView(); |
There was a problem hiding this comment.
This test is incorrect. it should be new BbView()
wesmangum
force-pushed
the
tests/onAttach-onDomRefresh-onDomRemove-templateRenderer
branch
from
c33a923
to
4e8c983
Compare
…ompiled template unit tests
wesmangum
force-pushed
the
tests/onAttach-onDomRefresh-onDomRemove-templateRenderer
branch
from
4e8c983
to
b1885f5
Compare
paulfalgout
approved these changes
Nov 23, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Link to the issue: #3248
This pr is a small part of the work to refactor the whole unit tests directory. Merging this issue should keep #3248 open