Fix :lang scala with :lang org
#5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need better test coverage to figure out how many more of these there are. I don't see a way of dealing with them better, but (unless they are revived) they should not change underneath us, so keeping these overrides does not seem too risky. Fix formatting for the sly-stepper pin while I'm there.
Triggered by ob-ammonite (used by scala, in emacsattic) depending on ammonite-term-repl (also in emacsattic). `eself` only contains emacs-overlay and doomPackageSet. All of this needs refactoring, but an explicit recursive call fixes the immediate problem.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not yet covered by tests, but should be once I dynamically generate an
init.elwith all modules and flags enabled. Build-tested locally.Should fix #3.