Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ob-ammonite: not in epkgs, not elpa, no recipe or not pinned #3

Closed
leifhelm opened this issue May 22, 2024 · 3 comments · Fixed by #5
Closed

ob-ammonite: not in epkgs, not elpa, no recipe or not pinned #3

leifhelm opened this issue May 22, 2024 · 3 comments · Fixed by #5
Assignees

Comments

@leifhelm
Copy link
Contributor

leifhelm commented May 22, 2024

I tried to use your package with org mode and scala enabled. The following error occured

ob-ammonite: not in epkgs, not elpa, no recipe or not pinned

but it is pinned in modules/lang/org/packages.el

(package! ob-ammonite :pin "39937dff395e70aff76a4224fa49cf2ec6c57cca"))
@marienz
Copy link
Owner

marienz commented May 22, 2024

Thanks for flagging!

I initially misread your report and found a different bug (filed as #4), triggered by enabling scala with org. Need to fix that later: probably not as common a problem (and can be worked around by either enabling the org module or disabling the org package).

I didn't notice this problem myself for the same reason the readme mentions "not all Doom module flags may work": basically all modules are covered individually, but modules that pull in additional packages if some other module is enabled aren't tested yet. I think I know how to fix this (walk all packages.el files and extract flags, more or less).

The underlying problem is two more packages from emacsattic, which isn't in emacs-overlay. The error message doesn't make that clear, I'll tweak that later. Once all modules and flags are properly tested, that may uncover a few more, but assuming emacsattic packages don't usually migrate back out of the attic just adding pins for them shouldn't be too bad.

It did uncover one more subtle problem: dependencies on packages neither in emacs-overlay nor explicitly depended upon or pinned by Doom weren't working.

Merging fix momentarily (which I build-tested locally)...

@marienz marienz assigned leifhelm and unassigned marienz May 22, 2024
@marienz
Copy link
Owner

marienz commented May 22, 2024

@leifhelm can you please confirm this fixes it for you? I build-tested this but I don't use scala so can't quickly test it beyond that.

@marienz marienz reopened this May 22, 2024
@leifhelm
Copy link
Contributor Author

Thank you for fixing this so quickly. It works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants