Get rid of regexes in CreditorIdentifier
#178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcwrobel
force-pushed
the
172-get-rid-of-regexes-in-creditoridentifier
branch
2 times, most recently
from
d2185f2 to
b639d58
Compare
marcwrobel
force-pushed
the
172-get-rid-of-regexes-in-creditoridentifier
branch
2 times, most recently
from
9801e17 to
801f8aa
Compare
This significantly increases the performances of BIC validation (x3) and creation (x4). As part of this change : - documentation has been improved, - REGEX has been made public for uniformisation and documentation purposes, - javadoc on private methods has been deleted.
marcwrobel
force-pushed
the
172-get-rid-of-regexes-in-creditoridentifier
branch
from
801f8aa to
b51d74d
Compare
marcwrobel
force-pushed
the
172-get-rid-of-regexes-in-creditoridentifier
branch
from
b51d74d to
810e2de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.