Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of regexes in CreditorIdentifier #172

Closed
marcwrobel opened this issue Jul 25, 2022 · 0 comments · Fixed by #178
Closed

Get rid of regexes in CreditorIdentifier #172

marcwrobel opened this issue Jul 25, 2022 · 0 comments · Fixed by #178
Labels
enhancement
Milestone
4.0.0

Comments

@marcwrobel
Copy link
Owner

Benchmarks have shown that most time in CreditorIdentifier is passed in the pattern validation. Replacing the use of a regex by a more "simpler" code should improve significantly the performances of CreditorIdentifier creation and validation.
@marcwrobel marcwrobel added this to the 4.0.0 milestone Jul 26, 2022
marcwrobel added a commit that referenced this issue Jul 26, 2022
@marcwrobel
Get rid of regexes in CreditorIdentifiers (closes #172)
712279c 
This significantly increases the performances of BIC validation (x3) and creation (x4).

As part of this change :
- documentation has been improved,
- REGEX has been made public for uniformisation and documentation purposes,
- javadoc on private methods has been deleted.
@marcwrobel marcwrobel linked a pull request Jul 26, 2022 that will close this issue
Get rid of regexes in CreditorIdentifier #178
Merged
marcwrobel added a commit that referenced this issue Jul 26, 2022
@marcwrobel
Get rid of regexes in CreditorIdentifiers (closes #172)
d2185f2 
This significantly increases the performances of BIC validation (x3) and creation (x4).

As part of this change :
- documentation has been improved,
- REGEX has been made public for uniformisation and documentation purposes,
- javadoc on private methods has been deleted.
marcwrobel added a commit that referenced this issue Jul 26, 2022
@marcwrobel
Get rid of regexes in CreditorIdentifiers (closes #172)
b639d58 
This significantly increases the performances of BIC validation (x3) and creation (x4).

As part of this change :
- documentation has been improved,
- REGEX has been made public for uniformisation and documentation purposes,
- javadoc on private methods has been deleted.
marcwrobel added a commit that referenced this issue Jul 26, 2022
@marcwrobel
Get rid of regexes in CreditorIdentifiers (closes #172)
9801e17 
This significantly increases the performances of BIC validation (x3) and creation (x4).

As part of this change :
- documentation has been improved,
- REGEX has been made public for uniformisation and documentation purposes,
- javadoc on private methods has been deleted.
marcwrobel added a commit that referenced this issue Jul 26, 2022
@marcwrobel
Get rid of regexes in CreditorIdentifiers (closes #172)
801f8aa 
This significantly increases the performances of BIC validation (x3) and creation (x4).

As part of this change :
- documentation has been improved,
- REGEX has been made public for uniformisation and documentation purposes,
- javadoc on private methods has been deleted.
marcwrobel added a commit that referenced this issue Jul 26, 2022
@marcwrobel
Get rid of regexes in CreditorIdentifiers (closes #172)
813b7b9 
This significantly increases the performances of BIC validation (x3) and creation (x4).

As part of this change :
- documentation has been improved,
- REGEX has been made public for uniformisation and documentation purposes,
- javadoc on private methods has been deleted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Get rid of regexes in CreditorIdentifier marcwrobel/jbanking
1 participant
@marcwrobel