Support z,x,y and record-returning funcs, table rework #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nyurik
changed the title
nyurik
changed the title
This was referenced Dec 4, 2022
Closed
* All tests and internal code now uses ST_TileEnvelope function * Remove `tile_bbox` * Rename test function sources for clarity - this will be needed in a subsequent PR to add other function tests
Can handle the `getmvt(z,x,y) -> [bytea,md5]` case and several others.
* All table sources now use the same system as functions * Proper table name escaping * Prepared statements might speed things up, but this is not certain because we prepare on each get request. At least now we can optimize in one place.
BREAKING: * srid is now the same type as PG -- i32 * renamed config vals `table_sources` and `function_sources` into `tables` and `functions` Fixes: * predictable order of instantiation * bounding boxes computed in parallel for all tables (when not configured) * split up discovery and query creation - this way user overrides happen before the final query is generated * more proper name escaping * lots of test improvements
* Fix id column issue * Detect if postgis is newer than 3.1 and use st_tileenvolope margin param
stepankuzmin
approved these changes
Dec 10, 2022
| assert_eq!(t, &["bytea", "text"]); | ||
| } | ||
| (None, None) => {} | ||
| _ => panic!("Invalid output record names or types"), |
There was a problem hiding this comment.
Maybe skip such functions and use warn! instead of panic! here?
There was a problem hiding this comment.
This is a validation that SQL matches Rust code -- and uses lots of asserts for that. In theory the whole thing can be rewritten to use warnings, but I would rather panic early and fix the logic bugs than to make it go unnoticed. TBD i guess
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can now handle several additional Postgres functions to get a tile, plus tons of small fixes
Multiple result variants
getmvt(z,x,y) -> [bytea,md5](single row with two columns)getmvt(z,x,y) -> [bytea](single row with a single column)getmvt(z,x,y) -> bytea(value)Multiple input parameter variants
getmvt(z, x, y)orgetmvt(zoom, x, y)(all 3 vars must be integers)getmvt(z, x, y, url_query), where instead ofurl_queryit could be any other name, but must be of type JSONBreaking
i32table_sourcesandfunction_sourcesintotablesandfunctionsFeatures and fixes
Notes
(PgSqlInfo, FunctionInfo)(or table) tupples containing SQL needed to get the tile.fixes #378
fixes #466
fixes #65
fixes #389