Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow auto discovery per schema #510

Merged
merged 17 commits into from
Dec 10, 2022
Merged

Allow auto discovery per schema #510

merged 17 commits into from
Dec 10, 2022

Conversation

nyurik
Copy link
Member

@nyurik nyurik commented Dec 9, 2022

Configuration refactoring to allow future schema filtering. This partially solves #47, but it does not expose the configuration to the user just yet.

nyurik added 13 commits December 6, 2022 21:41
* All tests and internal code now uses ST_TileEnvelope function
* Remove `tile_bbox`
* Rename test function sources for clarity - this will be needed in a subsequent PR to add other function tests
Can handle the `getmvt(z,x,y) -> [bytea,md5]` case and several others.
* All table sources now use the same system as functions
* Proper table name escaping
* Prepared statements might speed things up, but this is not certain because we prepare on each get request. At least now we can optimize in one place.
BREAKING:
* srid is now the same type as PG -- i32
* renamed config vals `table_sources` and `function_sources` into `tables` and `functions`

Fixes:
* predictable order of instantiation
* bounding boxes computed in parallel for all tables (when not configured)
* split up discovery and query creation - this way user overrides happen before the final query is generated
* more proper name escaping
* lots of test improvements
* Fix id column issue
* Detect if postgis is newer than 3.1 and use st_tileenvolope margin param
@nyurik nyurik enabled auto-merge (squash) December 10, 2022 19:47
@nyurik nyurik merged commit 171032c into maplibre:main Dec 10, 2022
@nyurik nyurik deleted the schemas-cfg branch December 10, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants