Sky + test #3648

acalcutt · 2024-02-01T05:36:45Z

First attempt to add tests to #3645

I added two expect tests
test\integration\render\tests\terrain\fog

test\integration\render\tests\terrain\sky

* add examples using deck.gl layers * Update deck.gl version in add-deckgl-layer-using-rest-api.html * Update deck.gl version in toggle-deckgl-layer.html * Fix lint issues in toggle-deckgl-layer.html add-deckgl-layer-using-rest-api.html * fix readability in add-deckgl-layer-using-rest-api.html and toggle-deckgl-layer.html * fix position of show variable in toggle-deckgl-layer.html

Bumps [rollup](https://github.com/rollup/rollup) from 4.9.5 to 4.9.6. - [Release notes](https://github.com/rollup/rollup/releases) - [Changelog](https://github.com/rollup/rollup/blob/master/CHANGELOG.md) - [Commits](rollup/rollup@v4.9.5...v4.9.6) --- updated-dependencies: - dependency-name: rollup dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.18.1 to 6.19.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.19.0/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.11.1 to 20.11.5. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [stylelint](https://github.com/stylelint/stylelint) from 16.1.0 to 16.2.0. - [Release notes](https://github.com/stylelint/stylelint/releases) - [Changelog](https://github.com/stylelint/stylelint/blob/main/CHANGELOG.md) - [Commits](stylelint/stylelint@16.1.0...16.2.0) --- updated-dependencies: - dependency-name: stylelint dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [devtools-protocol](https://github.com/ChromeDevTools/devtools-protocol) from 0.0.1245094 to 0.0.1249869. - [Changelog](https://github.com/ChromeDevTools/devtools-protocol/blob/master/changelog.md) - [Commits](ChromeDevTools/devtools-protocol@v0.0.1245094...v0.0.1249869) --- updated-dependencies: - dependency-name: devtools-protocol dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [jsdom](https://github.com/jsdom/jsdom) from 23.2.0 to 24.0.0. - [Release notes](https://github.com/jsdom/jsdom/releases) - [Changelog](https://github.com/jsdom/jsdom/blob/main/Changelog.md) - [Commits](jsdom/jsdom@23.2.0...24.0.0) --- updated-dependencies: - dependency-name: jsdom dependency-type: direct:development update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@types/react](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react) from 18.2.47 to 18.2.48. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react) --- updated-dependencies: - dependency-name: "@types/react" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…#3607) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.18.1 to 6.19.0. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.19.0/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…g asymettrical camera viewport and bearing (maplibre#3591) * failing test * tests fixes which were incorrect and code update * code improvements * small cleanup * fix linting findings * update changelog

* Replace v8 with monocart * Change to codecov format

* Fix docs * Fix image generation script * Fix escape character issues * Add missing docs annotation * Update src/ui/handler/tap_drag_zoom.ts --------- Co-authored-by: neodescis <[email protected]>

* Initial commit - not working... * Fixing initializing with esm exports (maplibre#3600) * Fixed custom define AMD function in order work with esm exports * Refactored custom define function to be a bit more stable for changes It still fragile to changes of dependencies order tho * Fix lint * Fix lint * Fix tests - missing return * Update test/integration/render/run_render_tests.ts Co-authored-by: Evgeniy Timokhov <[email protected]> * Update test/integration/render/run_render_tests.ts Co-authored-by: Evgeniy Timokhov <[email protected]> * Fixes to the docs, change back to umd, add pmtiles image * Fix lint and missing files * A few small corrections * Updated changelog, reduced complexity in prelude, update docs * Revert control changes * Revert changes to navigation control * remove file that is fixed in another PR. * Revert changes in docs images generator script * Remove unused types * Add expelicitly export reference types * Rename control options to reduce name collision * Improve docs generation, export everything that is needed for the docs * Remove debug additions to API --------- Co-authored-by: Evgeniy Timokhov <[email protected]>

* Bump version to 4.0.0-pre.5 * Update CHANGELOG.md --------- Co-authored-by: HarelM <[email protected]> Co-authored-by: Harel M <[email protected]>

* Filter a layer based on user input using setFilter(). * Add example image, fix og:description. Lint.

* Added missing types to export * Was missing in the event group * Fix lint

…e#3615) * Change the coverage for jest to be aligned with render tests * Add default reporter to see regular progress * Fix problem with coverage * Fix rename * Remove default reporter from ci * Remove unneeded files and configuration * Fix coverage file location

* Remove COMMUNITY.md file * Fix sponsorship tier

* Add setOpacity method to a Marker * Add tests for Marker.setOpacity * Add opacityWhenCovered * Change opacity props to numbers * Reset opacity when setOpacity is called without args * use setOpacity when initializing Marker * add expectedBytes * remove if * Add changelog entry * Change opacity to string * Add comment on setOpacity

* Remove internal mudule from docs * Remove maplibregl prefix from docs * Improve build robustness, Update API intro. * Update build/generate-docs.ts Co-authored-by: Bart Louwers <[email protected]> --------- Co-authored-by: Bart Louwers <[email protected]>

* Move all string to the same place * Update changelog * Fix lint * add partial according to code review * Update CHANGELOG.md Co-authored-by: Bart Louwers <[email protected]> * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Bart Louwers <[email protected]>

* Set attribution to be on by default * Update logo * Fix lint * Add changelog * Fixed tests * Update change log, update map API * Update README.md * Fix build and definitions * Add more time to test * Updated a note about attribution * reduce changes in tests * Revert icon change * revert size change, add logo example * revert unneeded changes

* Bump version to 4.0.0-pre.6 * remove bugs entry --------- Co-authored-by: HarelM <[email protected]> Co-authored-by: HarelM <[email protected]>

Bumps [puppeteer](https://github.com/puppeteer/puppeteer) from 21.7.0 to 21.9.0. - [Release notes](https://github.com/puppeteer/puppeteer/releases) - [Changelog](https://github.com/puppeteer/puppeteer/blob/main/release-please-config.json) - [Commits](puppeteer/puppeteer@puppeteer-v21.7.0...puppeteer-v21.9.0) --- updated-dependencies: - dependency-name: puppeteer dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [devtools-protocol](https://github.com/ChromeDevTools/devtools-protocol) from 0.0.1249869 to 0.0.1253004. - [Changelog](https://github.com/ChromeDevTools/devtools-protocol/blob/master/changelog.md) - [Commits](ChromeDevTools/devtools-protocol@v0.0.1249869...v0.0.1253004) --- updated-dependencies: - dependency-name: devtools-protocol dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@types/node](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/node) from 20.11.5 to 20.11.10. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/node) --- updated-dependencies: - dependency-name: "@types/node" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [ts-jest](https://github.com/kulshekhar/ts-jest) from 29.1.1 to 29.1.2. - [Release notes](https://github.com/kulshekhar/ts-jest/releases) - [Changelog](https://github.com/kulshekhar/ts-jest/blob/main/CHANGELOG.md) - [Commits](kulshekhar/ts-jest@v29.1.1...v29.1.2) --- updated-dependencies: - dependency-name: ts-jest dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

…#3639) Bumps [@typescript-eslint/eslint-plugin](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/eslint-plugin) from 6.19.0 to 6.19.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/eslint-plugin/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.19.1/packages/eslint-plugin) --- updated-dependencies: - dependency-name: "@typescript-eslint/eslint-plugin" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [pdf-merger-js](https://github.com/nbesli/pdf-merger-js) from 5.0.0 to 5.1.1. - [Release notes](https://github.com/nbesli/pdf-merger-js/releases) - [Commits](nbesli/pdf-merger-js@v5.0.0...v5.1.1) --- updated-dependencies: - dependency-name: pdf-merger-js dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [dts-bundle-generator](https://github.com/timocov/dts-bundle-generator) from 9.2.4 to 9.2.5. - [Release notes](https://github.com/timocov/dts-bundle-generator/releases) - [Commits](timocov/dts-bundle-generator@v9.2.4...v9.2.5) --- updated-dependencies: - dependency-name: dts-bundle-generator dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

Bumps [@typescript-eslint/parser](https://github.com/typescript-eslint/typescript-eslint/tree/HEAD/packages/parser) from 6.19.0 to 6.19.1. - [Release notes](https://github.com/typescript-eslint/typescript-eslint/releases) - [Changelog](https://github.com/typescript-eslint/typescript-eslint/blob/main/packages/parser/CHANGELOG.md) - [Commits](https://github.com/typescript-eslint/typescript-eslint/commits/v6.19.1/packages/parser) --- updated-dependencies: - dependency-name: "@typescript-eslint/parser" dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Test opacity of a partly visible marker * Commit to trigger gh action

Bumps [monocart-coverage-reports](https://github.com/cenfun/monocart-coverage-reports) from 2.3.0 to 2.3.3. - [Release notes](https://github.com/cenfun/monocart-coverage-reports/releases) - [Changelog](https://github.com/cenfun/monocart-coverage-reports/blob/main/CHANGELOG.md) - [Commits](cenfun/monocart-coverage-reports@2.3.0...2.3.3) --- updated-dependencies: - dependency-name: monocart-coverage-reports dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

codecov-commenter · 2024-02-01T05:43:08Z

Codecov Report

Attention: 24 lines in your changes are missing coverage. Please review.

Comparison is base (4e28671) 86.61% compared to head (91e010c) 66.14%.
Report is 10 commits behind head on main.

Files	Patch %	Lines
src/style/sky.ts	90.21%	4 Missing and 5 partials ⚠️
src/ui/map.ts	20.00%	8 Missing ⚠️
src/style/style.ts	76.66%	4 Missing and 3 partials ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##             main    #3648       +/-   ##
===========================================
- Coverage   86.61%   66.14%   -20.48%     
===========================================
  Files         240      241        +1     
  Lines       32214    32317      +103     
  Branches     2132     1310      -822     
===========================================
- Hits        27903    21375     -6528     
- Misses       3356    10131     +6775     
+ Partials      955      811      -144

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

HarelM · 2024-02-01T05:59:54Z

Thanks! Can you base your branch from sky2 and change the target branch of this PR to sky2? I see a lot of files changes here...

acalcutt · 2024-02-01T13:55:49Z

I opened a new PR targeted to the 'sky2' branch #3649 . I had tried to retarget this one but it just made the changes worse.

HarelM · 2024-02-01T14:13:06Z

Thanks!

ilci66 and others added 30 commits January 19, 2024 12:00

docs(readme): fix broken React bindings link (maplibre#3597)

7decb26

Improve docstring for queryTerrainElevation (maplibre#3599)

fc5f509

Bugfix: _cameraForBoxAndBearing not fitting bounds properly when usin…

533de48

…g asymettrical camera viewport and bearing (maplibre#3591) * failing test * tests fixes which were incorrect and code update * code improvements * small cleanup * fix linting findings * update changelog

Replace v8 with monocart for coverage (maplibre#3598)

390a0bc

* Replace v8 with monocart * Change to codecov format

Fix docs (maplibre#3611)

fa7372f

* Fix docs * Fix image generation script * Fix escape character issues * Add missing docs annotation * Update src/ui/handler/tap_drag_zoom.ts --------- Co-authored-by: neodescis <[email protected]>

Bump version to 4.0.0-pre.5 (maplibre#3619)

ff7591d

* Bump version to 4.0.0-pre.5 * Update CHANGELOG.md --------- Co-authored-by: HarelM <[email protected]> Co-authored-by: Harel M <[email protected]>

Filter a layer based on user input using setFilter(). (maplibre#3617)

41aee99

* Filter a layer based on user input using setFilter(). * Add example image, fix og:description. Lint.

Added MapMouseEvent type to export (maplibre#3622)

4ed9cf0

* Added missing types to export * Was missing in the event group * Fix lint

Remove COMMUNITY.md file, fix sponsorship tier (maplibre#3630)

0e27f8b

* Remove COMMUNITY.md file * Fix sponsorship tier

Add new logo as grayscale (maplibre#3631)

8ce93cb

Bump version to 4.0.0-pre.6 (maplibre#3633)

fe7835b

* Bump version to 4.0.0-pre.6 * remove bugs entry --------- Co-authored-by: HarelM <[email protected]> Co-authored-by: HarelM <[email protected]>

add pr link in changelog (maplibre#3634)

4e28671

dependabot bot and others added 9 commits January 29, 2024 08:16

Test opacity of a partly visible marker (maplibre#3644)

10f0104

* Test opacity of a partly visible marker * Commit to trigger gh action

Merge remote-tracking branch 'upstream/sky2' into sky-test2

a99fb22

add sky/fog expect tests

91e010c

acalcutt mentioned this pull request Feb 1, 2024

Sky Implementation according to spec #3645

Merged

HarelM changed the base branch from main to sky2 February 1, 2024 05:58

HarelM changed the base branch from sky2 to main February 1, 2024 05:58

acalcutt changed the base branch from main to sky2 February 1, 2024 13:35

acalcutt closed this Feb 1, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sky + test #3648

Sky + test #3648

acalcutt commented Feb 1, 2024

codecov-commenter commented Feb 1, 2024 •

edited

Loading

HarelM commented Feb 1, 2024

acalcutt commented Feb 1, 2024 •

edited

Loading

HarelM commented Feb 1, 2024

Sky + test #3648

Sky + test #3648

Conversation

acalcutt commented Feb 1, 2024

codecov-commenter commented Feb 1, 2024 • edited Loading

Codecov Report

HarelM commented Feb 1, 2024

acalcutt commented Feb 1, 2024 • edited Loading

HarelM commented Feb 1, 2024

codecov-commenter commented Feb 1, 2024 •

edited

Loading

acalcutt commented Feb 1, 2024 •

edited

Loading