Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new logo as grayscale #3631

Merged
merged 1 commit into from
Jan 28, 2024
Merged

Add new logo as grayscale #3631

merged 1 commit into from
Jan 28, 2024

Conversation

wipfli
Copy link
Contributor

@wipfli wipfli commented Jan 27, 2024

Adds the new logo as gray scale like the old one was. I did some inkscape stuff with outlines and strokes and paths and what not but now I think it looks very much like the previous version, just with the new shape...

image

This pull request also removes a png with the old logo which we don't use anywhere I think...

Launch Checklist

  • Confirm your changes do not include backports from Mapbox projects (unless with compliant license) - if you are not sure about this, please ask!
  • Briefly describe the changes in this PR.
  • Link to related issues.
  • Include before/after visuals or gifs if this PR includes visual changes.
  • Write tests for all new functionality.
  • Document any changes to public APIs.
  • Post benchmark scores.
  • Add an entry to CHANGELOG.md under the ## main section.

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4ed9cf0) 83.33% compared to head (92a9cda) 87.12%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3631      +/-   ##
==========================================
+ Coverage   83.33%   87.12%   +3.79%     
==========================================
  Files         243      240       -3     
  Lines       32194    32189       -5     
  Branches     4442     2080    -2362     
==========================================
+ Hits        26829    28045    +1216     
+ Misses       5122     3226    -1896     
- Partials      243      918     +675     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wipfli
Copy link
Contributor Author

wipfli commented Jan 27, 2024

This should fail a render test I assume...

@louwers
Copy link
Collaborator

louwers commented Jan 28, 2024

This should fail a render test I assume...

Does it get fed to the renderer or is it just layed on top of the canvas?

Edit: Looks like the latter:

background-image: svg-load("svg/maplibregl-ctrl-logo.svg");

@HarelM
Copy link
Collaborator

HarelM commented Jan 28, 2024

It shouldn't fail a render test, this control is over the map and not part of the canvas, the render test are comparing the canvas pixels...

@HarelM
Copy link
Collaborator

HarelM commented Jan 28, 2024

Can you please change the base branch to the attribution branch?

@HarelM HarelM merged commit 8ce93cb into main Jan 28, 2024
15 checks passed
@HarelM HarelM deleted the add-grayscale-new-logo branch January 28, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants