Add queryTerrainElevation method #2264
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HarelM
reviewed
Mar 13, 2023
HarelM
reviewed
Mar 13, 2023
HarelM
reviewed
Mar 13, 2023
|
Thanks for taking the time to do this! |
|
Hi @HarelM do I need to tick all of check boxes? |
|
Hi @HarelM! How to make sure that my code does not include backports from Mapbox projects? |
HarelM
reviewed
Mar 14, 2023
HarelM
reviewed
Mar 14, 2023
HarelM
reviewed
Mar 14, 2023
HarelM
reviewed
Mar 14, 2023
|
See my comments, if you haven't looked at the mapbox code in order to implement this then you didn't backported it. |
|
Actually, Mapbox has queryTerrainElevation but the implementation is different |
…e#2241) * shouldPausePlacement short circuits when _forceFullPlacement * Update CHANGELOG.md * Update src/style/pauseable_placement.ts Co-authored-by: David Schlosnagle <[email protected]> --------- Co-authored-by: Harel M <[email protected]>
Bumps [playwright](https://github.com/Microsoft/playwright) from 1.31.1 to 1.31.2. - [Release notes](https://github.com/Microsoft/playwright/releases) - [Commits](microsoft/playwright@v1.31.1...v1.31.2) --- updated-dependencies: - dependency-name: playwright dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* Unit test coverage * rename upload step * use my favorite test reporters text reporter provides output in ci log html-spa reporter provides friendly and interactive output * upload coverage even if unit tests fail
|
There are a small conflict in CHANGELOG.md, can you help me with resolving it @HarelM ? |
|
Seems like this PR contains files from different PRs. |
|
I tried to rebase from master to solve the conflict of Changlog.md
On Thu, 16 Mar 2023 at 13:17 Harel M ***@***.***> wrote:
Seems like this PR contains files from different PRs.
You'll need to fix that either using for commands or opening a different
PR...
—
Reply to this email directly, view it on GitHub
<#2264 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/APC3BGQHHLXIXJEGLLDDC7DW4KV6HANCNFSM6AAAAAAVYQQYCI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
--
----------------------------------------------------------------------
Nguyễn Mạnh Cường
Tel: 0934177324
|
|
I suggest to open a different branch from current main and do the changes on it again if you can't solve this otherwise... |
|
Okay @HarelM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1654
Launch Checklist
CHANGELOG.mdunder the## mainsection.