-
-
Notifications
You must be signed in to change notification settings - Fork 717
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reinstate CI unit test coverage #2274
Conversation
text reporter provides output in ci log html-spa reporter provides friendly and interactive output
@HarelM Coverage reports are a cool resource, but we need to increase the baseline coverage (maybe include integration tests too?) before this report really becomes useful. https://github.com/maplibre/maplibre-gl-js/suites/11560050540/artifacts/598609701 |
I agree coverage should be increased, but I want to be able to easily see the current coverage on a file that was changed as part of a PR and thus let the PR owner know that they need to improve coverage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this need .gitignore changes?
Yeah, this is not geared toward
Can you point me to a repo that does this well? I bet it's not too hard to check for coverage changes on PR (though I still have reservations about doing this while integration/render tests aren't considered in coverage numbers).
I don't know what you mean by this.
Nope. |
See here - I was hoping this action might do the trick, there might be other actions, IDK, I'm using codecov in another project and it works well. This is my other project: |
I'm keeping this PR as-is. Let's see what we can do with the current coverage reports before we add another action item to each PR. |
* Unit test coverage * rename upload step * use my favorite test reporters text reporter provides output in ci log html-spa reporter provides friendly and interactive output * upload coverage even if unit tests fail
Launch Checklist
PR #2044 removed the unit test coverage reports. This PR reinstates them and uploads the coverage reports as build artifacts.
Per #2044 (comment)
CHANGELOG.md
under the## main
section.