Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unless c++14 is absolutely needed, we should stick to building/testing/supporting C++11.
I took a look at whether all the tests would build and pass in C++11. They do - the only thing requiring C++14 was the
#include <mapbox/geometry.hpp>
that indirectly pulled inmapbox/geometry/feature.hpp
which pulls instd::experimental::optional
from https://github.com/mapbox/geometry.hpp/blob/b0e41cc5635ff8d50e7e1edb73cadf1d2a7ddc83/include/mapbox/geometry/feature.hpp#L11.Ideally, in my view
geometry.hpp
would be configured in such a way thatstd::experimental::optional
is not forced on downstream users. Until this is fixed, simply using#include <mapbox/geometry/geometry.hpp>
solves the problem elegantly and allows us to build in C++11 mode.