Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure each header compiles on its own #20

Open
springmeyer opened this issue Nov 7, 2017 · 0 comments
Open

Ensure each header compiles on its own #20

springmeyer opened this issue Nov 7, 2017 · 0 comments
Milestone

Comments

@springmeyer
Copy link
Contributor

By ensuring each header compiles on its own, we're able to insure we are "including what we use". I noticed that libosium from @joto has nice trick for doing this: https://github.com/osmcode/libosmium/blob/28c676054064c6b75204f0981c21fb3e265c9319/CMakeLists.txt#L386-L421.

We should apply that here to catch instances where we are missing includes (and therefore depending inadvertently on includes including other includes which may not be the same per platform).

@flippmoke flippmoke added this to the v1.0 milestone Feb 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants