-
Notifications
You must be signed in to change notification settings - Fork 314
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Navigation Native, Part 2 #1618
Merged
Merged
Changes from all commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
faf2e4a
Bring in nav-native
frederoni f4d0cd5
Fix Obj-C example
frederoni 324b767
Bump dependencies
frederoni 8ac2a7e
Update to nav-native 3.0
frederoni 4c40994
Switch to dynamic flavor of nav-native and fix merge conflicts
frederoni 05e13b0
Link and embed MapboxNavigationNative in CarPlay example app
f536153
Documenting `NavigationService`, updating existing docs.
351fac4
Hooking up the Carplay End Of Route template to the very-much-extant …
919c458
Pin nav-native to specific version
frederoni 8e160c8
Replace conversion functions with initializers
frederoni e1d0b10
NativeRouteController -> PortableRouteController
frederoni 0e124c0
Add a meaningful assertion message
frederoni b18dae9
func -> computed property
frederoni 3883aad
Merge branch 'epic/nav-native' into nav-native-2
a3fbaed
PR Comments, Removing accidental usage of over-the-wire Directions cl…
8b389d0
Fix up test overlooked by running on wrong sim version
a41c39d
Fix up CarPlayManager conditional providing of MapboxNavigationService
d28008b
Public documentation updates
9e9e582
Upgrading Nav-Native deliverable and switching default router over to…
90e325b
Fixing issue where the NVC didn't have the correct method signature
be50df4
Fixing issue where off-routing at intersection between steps would no…
e55fb31
Fixing testing issue where Native Navigator requires a few 'good' upd…
9ef649c
Fixing issue where apple links things spookily when you don't refer t…
aa040be
Updating cartfile resolution for newest build
dc32804
Adding obsoletes to initalizers
8d02b40
Changing `isInTunnel` to be an instance method -- which will help us …
3b83a71
typo
f223972
updating release version resolution
12ba9da
Adding additional obsoletes, moving all to extension, removing RMVC a…
3aa45f1
Adding proper access keywords onto `ExitView` and `GenericRouteShield…
ab721c5
Adding proper privacy modifiers for `ExitView`. Also adding some miss…
eff5a53
YES ONLY END SIMULATION IF WE'RE NOT SIMULATING BRILLIANT IDEA JERRAD
5215374
Arm the timer on the first good location update.
41f8d9d
Update dependencies
96c28d5
Remove pinned branch of MapboxDirections from Podfile integration test
4a87a13
Updating pod integation Podfile.lock
afce27d
Fixing issues in relation to poor GPS route simulation
1c78fce
typo
0bbcb07
Merge branch 'epic/nav-native' into nav-native-2
cab8775
Updating carfile
f738d16
Improving changelog, adding readme update
858767b
Pinning nav-native to 3.1.4
9008fe4
This sounds nice
43d3cce
Update CHANGELOG.md
1ec5 5fcf351
ONE MORE TIME
b281a9e
just kidding
74e9f72
YES SORRY MISTER PODFILE TEST CANT FORGET ABOUT YOU
5e737e0
also bringing in the project changes
a4c59eb
updating jazzy
9c6c932
Updating cover doc
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,12 +1,13 @@ | ||
binary "https://www.mapbox.com/ios-sdk/Mapbox-iOS-SDK.json" "4.4.1" | ||
binary "https://www.mapbox.com/ios-sdk/MapboxNavigationNative.json" "3.1.4" | ||
github "CedarBDD/Cedar" "v1.0" | ||
github "Quick/Nimble" "v7.3.1" | ||
github "Quick/Quick" "v1.3.2" | ||
github "ceeK/Solar" "2.1.0" | ||
github "mapbox/MapboxDirections.swift" "v0.23.0" | ||
github "mapbox/MapboxDirections.swift" "v0.24.0" | ||
github "mapbox/MapboxGeocoder.swift" "v0.10.0" | ||
github "mapbox/mapbox-events-ios" "v0.5.1" | ||
github "mapbox/mapbox-voice-swift" "v0.0.1" | ||
github "mapbox/turf-swift" "v0.2.0" | ||
github "mapbox/mapbox-voice-swift" "v0.0.2" | ||
github "mapbox/turf-swift" "v0.2.1" | ||
github "raphaelmor/Polyline" "v4.2.0" | ||
github "uber/ios-snapshot-test-case" "4.0.0" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,16 @@ | ||
import Foundation | ||
import MapboxNavigationNative | ||
import CoreLocation | ||
|
||
extension MBFixLocation { | ||
|
||
convenience init(_ location: CLLocation) { | ||
self.init(location: location.coordinate, | ||
time: location.timestamp, | ||
speed: location.speed as NSNumber, | ||
bearing: location.course as NSNumber, | ||
altitude: location.altitude as NSNumber, | ||
accuracyHorizontal: location.horizontalAccuracy as NSNumber, | ||
provider: nil) | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does MapboxNavigationNative handle polyline 5 format gracefully? If not, this is the first property being set here that the SDK strictly requires. Perhaps we should assert on the use of polyline 6 format or just go ahead and set it at the point of use in addition to here.