Navigation Native, Part 2 #1618

frederoni · 2018-08-23T13:26:04Z

This branch is targeting ~~jerrad/146-navigation-service~~ epic/nav-native.

Move getDirections out of extension to allow overriding it CLLocation<->MBFixLocation Bring in nav-native Add native route controller Support for alternate routes

…`endNavigation(feedback:)` Navigation Service method.

1ec5 · 2018-09-28T01:52:58Z

MapboxCoreNavigation/NavigationService.swift

 @objc(MBNavigationService)
 public protocol NavigationService: CLLocationManagerDelegate, RouterDataSource, EventsManagerDataSource {
+    /**
+     The services' location manager. This will be the object responsible for notifying the service of GPS updates.


This is fine, but you can also say “the services object’s”, so it doesn’t sound like the manager has multiple owners.

1ec5 · 2018-09-28T01:54:30Z

MapboxCoreNavigation.podspec

@@ -40,6 +40,7 @@ Pod::Spec.new do |s|
  s.requires_arc = true
  s.module_name = "MapboxCoreNavigation"

+  s.dependency "MapboxNavigationNative"


Pin to a specific version or use the tadpole operator. Don’t float on the latest version, because someone who installs this version of the SDK might face dependency hell down the line.

yes, especially as it is under such active development

1ec5 · 2018-09-28T01:56:33Z

MapboxCoreNavigation/CLLocation.swift

@@ -174,4 +175,14 @@ extension CLLocation {
        }
        return true
    }
+
+    func asMBFixLocation() -> MBFixLocation {


Write this as an initializer on an extension of MBFixLocation.

1ec5 · 2018-09-28T01:57:21Z

MapboxCoreNavigation/CLLocation.swift

+    func asMBFixLocation() -> MBFixLocation {
+        return MBFixLocation(location: coordinate,
+                             time: timestamp,
+                             speed: NSNumber(value: speed),


Nit: you can cast as NSNumber instead of using this initializer.

Cartfile

1ec5 · 2018-09-28T02:24:04Z

MapboxCoreNavigation/NavigationService.swift

+
+     A setting of `.always` will simulate route progress at all times.
+     A setting of `.onPoorGPS` will enable simulation when we do not recieve a location update after the `poorGPSPatience` threshold has elapsed.
+     A setting of `.never` will never enable the location simulator, regardless of circumstances.


These settings are already documented on SimulationOption, right?

1ec5 · 2018-09-28T02:26:35Z

MapboxCoreNavigation/NavigationService.swift

+
+    /**
+     The simulation mode of the service.
+     */
    var simulationMode: SimulationOption { get }


Why is the type SimulationOption but the property simulationMode?

1ec5 · 2018-09-28T02:27:56Z

MapboxCoreNavigation/NavigationService.swift

+     - parameter route: The route to follow.
+     - parameter directions: The Directions object that created `route`.
+     - parameter locationSource: An optional override for the default `NaviationLocationManager`.
+     - parameter eventsManagerType: A type argument used for overriding the events manager.


What is a “type argument”? I think this is descriptive enough:

An optional events manager to use while tracking the route.

1ec5 · 2018-09-28T02:29:08Z

MapboxCoreNavigation/Router.swift

@@ -11,6 +11,10 @@ public protocol RouterDataSource {
 @objc public protocol Router: class, CLLocationManagerDelegate {
    @objc unowned var dataSource: RouterDataSource { get }
    @objc var delegate: RouterDelegate? { get set }
+
+    @objc(initWithRoute:directions:locationManager:)
+    init(along route: Route, directions: Directions, dataSource source: RouterDataSource)


Given that this initializer is exposed to Objective-C, does it need to be public as well?

The Router protocol is public so this initializer is public as well despite the missing access modifier.

1ec5 · 2018-09-28T02:30:18Z

MapboxCoreNavigationTests/CocoaPodsTest/PodInstall/Podfile

@@ -5,4 +5,5 @@ target 'PodInstall' do
  # The branch of MapboxNavigation and MapboxNavigation will be replaced by Bitrise to use the current branch.
  pod 'MapboxNavigation', :path => '../../../'
  pod 'MapboxCoreNavigation', :path => '../../../'
+  pod 'MapboxDirections.swift', :git => '[email protected]:mapbox/MapboxDirections.swift.git', :branch => 'return-response'


Remember to remove this explicit dependency once we’re back on an official release.

1ec5

In addition to the following feedback, I get the feeling we should say something in the changelog, even if it’s just waxing nostalgic about all the problems we think have gone away by migrating to the MapboxNavigationNative framework.

Speaking of that framework, we should list any new transitive dependencies here in the Carthage installation instructions:

mapbox-navigation-ios/README.md

Line 57 in 96c28d5

    
           1. Follow the rest of [Carthage’s iOS integration instructions](https://github.com/Carthage/Carthage#if-youre-building-for-ios-tvos-or-watchos). Your application target’s Embedded Frameworks should include MapboxNavigation.framework and MapboxCoreNavigation.framework.

and that might be worth a mention in the changelog too.

Cartfile

akitchen · 2018-10-01T02:59:27Z

all the problems we think have gone away by migrating to the MapboxNavigationNative framework.

"benefits from a new off-route detection heuristic provided by Mapbox's cross-platform native navigation library"

?

/cc @mcwhittemore

mcwhittemore · 2018-10-01T03:53:29Z

nav-native is providing route following, location filtering, guidance triggering and location projection support. I'd call this logic move out in the changelog definitely.

akitchen · 2018-10-01T04:27:19Z

Let’s only call out the portions we’re using on iOS — as we move more functionality over we can call it out then

1ec5 · 2018-10-01T07:20:30Z

Cartfile

@@ -1,5 +1,5 @@
 binary "https://www.mapbox.com/ios-sdk/Mapbox-iOS-SDK.json" ~> 4.3
-binary "https://s3.amazonaws.com/mapbox/mapbox-navigation-native/ios/builds/Mapbox-iOS-Navigation-Native.json"
+binary "https://www.mapbox.com/ios-sdk/MapboxNavigationNative.json"


Pin to a specific version of this dependency.

1ec5

Looks good, other than the one nitpick about dependency versioning, which can always be loosened up later if need be.

1ec5 · 2018-10-01T07:37:34Z

Cartfile

@@ -1,5 +1,5 @@
 binary "https://www.mapbox.com/ios-sdk/Mapbox-iOS-SDK.json" ~> 4.3
-binary "https://www.mapbox.com/ios-sdk/MapboxNavigationNative.json"
+binary "https://www.mapbox.com/ios-sdk/MapboxNavigationNative.json" ~> 3.1.4


My understanding is that this library will respect semver, so it’s OK to float on the minor version as well as the patch version, just as we do in the map SDK.

/cc @kevinkreiser

The podspec specifies ~> 3.0, so let’s be consistent with that.

1ec5

Get this over with. 😛

frederoni added the ⚠️ DO NOT MERGE PR should not be merged! label Aug 23, 2018

frederoni force-pushed the nav-native-2 branch 11 times, most recently from 10189f1 to 7dd816c Compare August 30, 2018 12:45

JThramer changed the base branch from jerrad/146-navigation-service to epic/nav-native September 21, 2018 20:20

JThramer changed the base branch from epic/nav-native to jerrad/146-navigation-service September 21, 2018 20:20

frederoni changed the base branch from jerrad/146-navigation-service to master September 27, 2018 18:46

JThramer changed the base branch from master to epic/nav-native September 27, 2018 18:57

frederoni added 4 commits September 27, 2018 21:06

Bring in nav-native

faf2e4a

Move getDirections out of extension to allow overriding it CLLocation<->MBFixLocation Bring in nav-native Add native route controller Support for alternate routes

Fix Obj-C example

f4d0cd5

Bump dependencies

324b767

Update to nav-native 3.0

8ac2a7e

frederoni force-pushed the nav-native-2 branch from 766e1bb to 72149e7 Compare September 27, 2018 19:52

Switch to dynamic flavor of nav-native and fix merge conflicts

4c40994

frederoni force-pushed the nav-native-2 branch from 72149e7 to 4c40994 Compare September 27, 2018 20:03

Andrew Kitchen and others added 3 commits September 27, 2018 13:47

Link and embed MapboxNavigationNative in CarPlay example app

05e13b0

Documenting NavigationService, updating existing docs.

f536153

Hooking up the Carplay End Of Route template to the very-much-extant …

351fac4

…`endNavigation(feedback:)` Navigation Service method.

JThramer added ⏎ Ready To Merge and removed ⚠️ DO NOT MERGE PR should not be merged! labels Sep 28, 2018

1ec5 reviewed Sep 28, 2018

View reviewed changes

Andrew Kitchen added 2 commits September 30, 2018 19:47

Remove pinned branch of MapboxDirections from Podfile integration test

96c28d5

Updating pod integation Podfile.lock

4a87a13

1ec5 reviewed Oct 1, 2018

View reviewed changes

Cartfile Outdated Show resolved Hide resolved

Jerrad Thramer added 2 commits September 30, 2018 21:02

Fixing issues in relation to poor GPS route simulation

afce27d

typo

1c78fce

Jerrad Thramer added 2 commits October 1, 2018 01:09

Merge branch 'epic/nav-native' into nav-native-2

0bbcb07

Updating carfile

cab8775

akitchen approved these changes Oct 1, 2018

View reviewed changes

1ec5 reviewed Oct 1, 2018

View reviewed changes

akitchen mentioned this pull request Oct 1, 2018

Add obsoleted stubs for pre-NavigationService symbols #1746

Closed

Jerrad Thramer and others added 4 commits October 1, 2018 01:28

Improving changelog, adding readme update

f738d16

Pinning nav-native to 3.1.4

858767b

This sounds nice

9008fe4

Update CHANGELOG.md

43d3cce

1ec5 approved these changes Oct 1, 2018

View reviewed changes

Jerrad Thramer added 2 commits October 1, 2018 01:39

ONE MORE TIME

5fcf351

just kidding

b281a9e

1ec5 approved these changes Oct 1, 2018

View reviewed changes

Jerrad Thramer added 4 commits October 1, 2018 01:49

YES SORRY MISTER PODFILE TEST CANT FORGET ABOUT YOU

74e9f72

also bringing in the project changes

5e737e0

updating jazzy

a4c59eb

Updating cover doc

9c6c932

JThramer merged commit 45b74c0 into epic/nav-native Oct 1, 2018

1ec5 added the backwards incompatible changes that break backwards compatibility of public API label Dec 18, 2018

1ec5 mentioned this pull request Jan 10, 2019

Polyline 6 encoding #631

Closed

1ec5 deleted the nav-native-2 branch December 5, 2019 18:17

1ec5 mentioned this pull request Jun 25, 2021

Announcement: License is changing to Mapbox Terms of Service #3115

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Navigation Native, Part 2 #1618

Navigation Native, Part 2 #1618

frederoni commented Aug 23, 2018 •

edited

Loading

1ec5 Sep 28, 2018

1ec5 Sep 28, 2018 •

edited

Loading

akitchen Sep 28, 2018

1ec5 Sep 28, 2018

1ec5 Sep 28, 2018

1ec5 Sep 28, 2018

1ec5 Sep 28, 2018

1ec5 Sep 28, 2018 •

edited

Loading

1ec5 Sep 28, 2018

frederoni Sep 28, 2018 •

edited

Loading

1ec5 Sep 28, 2018

1ec5 left a comment •

edited

Loading

akitchen commented Oct 1, 2018

mcwhittemore commented Oct 1, 2018

akitchen commented Oct 1, 2018

1ec5 Oct 1, 2018

1ec5 left a comment

1ec5 Oct 1, 2018

1ec5 Oct 1, 2018

1ec5 left a comment

Navigation Native, Part 2 #1618

Navigation Native, Part 2 #1618

Conversation

frederoni commented Aug 23, 2018 • edited Loading

Choose a reason for hiding this comment

1ec5 Sep 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 Sep 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

frederoni Sep 28, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 left a comment • edited Loading

Choose a reason for hiding this comment

akitchen commented Oct 1, 2018

mcwhittemore commented Oct 1, 2018

akitchen commented Oct 1, 2018

Choose a reason for hiding this comment

1ec5 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

1ec5 left a comment

Choose a reason for hiding this comment

frederoni commented Aug 23, 2018 •

edited

Loading

1ec5 Sep 28, 2018 •

edited

Loading

1ec5 Sep 28, 2018 •

edited

Loading

frederoni Sep 28, 2018 •

edited

Loading

1ec5 left a comment •

edited

Loading