Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added rotary convenience methods #329

Merged
merged 2 commits into from
Feb 20, 2017
Merged

Conversation

ghoshkaj
Copy link
Contributor

@ghoshkaj ghoshkaj commented Feb 15, 2017

@ghoshkaj ghoshkaj changed the title added rotarty convenience methods added rotary convenience methods Feb 15, 2017
* @return String with the pronunciation
* @since 2.0.0
*/
public String getPronunciation() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ghoshkaj why two getters for the same field getRotaryPronunciation and getPronunciation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because I messed up :D fixed it!

@ghoshkaj ghoshkaj merged commit 848a11a into master Feb 20, 2017
@zugaldia zugaldia mentioned this pull request Feb 22, 2017
9 tasks
@zugaldia zugaldia mentioned this pull request Mar 9, 2017
9 tasks
@zugaldia zugaldia mentioned this pull request Mar 17, 2017
9 tasks
@cammace cammace deleted the rotary-convenience-methods branch August 1, 2017 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants