Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conveniences to Position model #309

Merged
merged 2 commits into from
Feb 8, 2017
Merged

Conveniences to Position model #309

merged 2 commits into from
Feb 8, 2017

Conversation

zugaldia
Copy link
Member

@zugaldia zugaldia commented Feb 7, 2017

This PR does two things:

This last item is tested via the Test App. In MainActivity we create an object with values out of range and the warning can be seen as usual in the Android log window:

image

@cammace Please review.

@mention-bot
Copy link

@zugaldia, thanks for your PR! By analyzing the history of the files in this pull request, we identified @cammace and @ivovandongen to be potential reviewers.

Copy link
Contributor

@cammace cammace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 love the warning given now

@zugaldia zugaldia merged commit 16c10e5 into master Feb 8, 2017
@zugaldia zugaldia deleted the az-position branch February 8, 2017 15:26
@1ec5
Copy link
Contributor

1ec5 commented Feb 8, 2017

Position is still used with the Android SDK's runtime styling API, right? Note that out-of-range longitudes are expected for features that straddle the antimeridian.

@zugaldia
Copy link
Member Author

zugaldia commented Feb 8, 2017

@1ec5 Right, we're tracking a couple of antimeridian-related issues here.

@1ec5
Copy link
Contributor

1ec5 commented Feb 8, 2017

Yes, but doesn’t antimeridian straddling already work in the Android SDK? mapbox/mapbox-gl-native#6088 Or does that affect only annotations, which would use the SDK-specific model objects?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants