Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Position check for correct order #266

Closed
cammace opened this issue Jan 10, 2017 · 1 comment
Closed

Add Position check for correct order #266

cammace opened this issue Jan 10, 2017 · 1 comment

Comments

@cammace
Copy link
Contributor

cammace commented Jan 10, 2017

When creating a Position object, many users accidentally switch up the latitude and longitude values. I propose adding a check so that if the latitude is over 90.0 we throw an error. While this wont always catch the error, it might help out users. We can also make the invalid position error more clear on this issue.

@zugaldia
Copy link
Member

I like it. I wouldn't throw an error but a warning, as the user might be handling coordinates that need to be wrapped.

Related: #283.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants