-
Notifications
You must be signed in to change notification settings - Fork 120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RxJava support #304
RxJava support #304
Conversation
Alright, nothing that couldn't be fixed bringing some generics to the
(Working sample in If this looks good to @mapbox/android we just need to bring in some test and adapt the same approach to the other clients (distance, geocoding, mapmatching, |
Would it make sense to also have a |
Yes, but let's wait to have some content before we create the module. For example, #4 should closed for now as it's unclear that the benefits of the Rx approach in the widget outbalance the weight of the dependency. @cammace PR is ready, care to review please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
WIP to bring back support for Rx as part of the
libjava-services-rx
module.The first stab at it, extending the current
MapboxDirections
class, works but brings an inconsistent API. Unlike with the normal client where theBuilder
brings theMapboxDirections
instance. Right now, we need to use them separately as we cannot use thebuild
method:This needs one more iteration.
Fixes #131.
cc: @mapbox/android for folks familiar with Rx willing to get some 👀.