Adds support for polyline6 #287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cammace
changed the title
cammace
force-pushed
the
cam-routeutils-refactor
branch
from
c6cfd41
to
011ae58
Compare
cammace
changed the title
|
I've fixed up this PR to only add support for precision 6 in the directions api. The route utils refactor will come laster down the road but I don't expect it to break the API. |
zugaldia
requested changes
Feb 8, 2017
| @@ -26,6 +26,7 @@ | |||
| public static final int GOOGLE_PRECISION = 5; | |||
| public static final int OSRM_PRECISION_V4 = 6; | |||
| public static final int OSRM_PRECISION_V5 = 5; | |||
| public static final int OSRM_PRECISION_6_V5 = 6; | |||
| // We only support polyline encoded geometries to reduce the size of the response. | ||
| // If we need the corresponding LineString object, this SDK can do the decoding with | ||
| // LineString.fromPolyline(String polyline, int precision). | ||
| // by defauly the geometry is polyline with precision 5. | ||
| this.geometries = DirectionsCriteria.GEOMETRY_POLYLINE; |
There was a problem hiding this comment.
@cammace Let's default to precision 6. That's what I do on MapMatching and the payload isn't much bigger but there's a gain in precision.
cammace
force-pushed
the
cam-routeutils-refactor
branch
from
008183e
to
f28d5aa
Compare
zugaldia
approved these changes
Feb 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #207
Closes #288
Bring over the work done in #228 and completes it.