v8 Omnibus #264

tmcw · 2015-03-12T15:29:18Z

Patches:

JS, Native

Changes

Font stacks as arrays. Fixes Font stacks should be arrays #257.

JS v8 Spec mapbox-gl-js#1081
Native v8 Omnibus 2 mapbox-gl-native#993

Spec

mapbox-gl-style-spec/reference/v8.json

Lines 462 to 471 in 2b7c377

    
           "text-font": { 
        
             "type": "array", 
        
             "value": "string", 
        
             "function": "piecewise-constant", 
        
             "default": ["Open Sans Regular", "Arial Unicode MS Regular"], 
        
             "doc": "Font stack to use for displaying text.", 
        
             "requires": [ 
        
               "text-field" 
        
             ] 
        
           },

Migration

mapbox-gl-style-spec/migrations/v8.js

Lines 44 to 50 in 2b7c377

    
           eachLayout(layer, function(layout) { 
        
               if (typeof layout['text-font'] === 'string') { 
        
                   layout['text-font'] = layout['text-font'].split(',') 
        
                       .map(function(s) { 
        
                           return s.trim(); 
        
                       }); 
        
               }

Tests
Styles

Permit map properties (centerpoint) Fixes centerpoint #247
- JS: no changes
- Native: no changes
- Migration: no changes
- Spec
- Styles

Rename symbol-min-distance to symbol-spacing. Fixes rename symbol-min-distance to symbol-spacing #252

JS
Native v8 Omnibus 2 mapbox-gl-native#993

Spec

mapbox-gl-style-spec/reference/v8.json

Lines 315 to 326 in 2b7c377

    
           "symbol-spacing": { 
        
             "type": "number", 
        
             "default": 250, 
        
             "minimum": 1, 
        
             "function": "interpolated", 
        
             "units": "pixels", 
        
             "doc": "Minimum distance between two symbol anchors.", 
        
             "requires": [ 
        
               { 
        
                 "symbol-placement": "line" 
        
               } 
        
             ]

Migration

mapbox-gl-style-spec/migrations/v8.js

Lines 51 to 53 in 2b7c377

    
           if (layout['symbol-min-distance'] !== undefined) { 
        
               renameProperty(layout, 'symbol-min-distance', 'symbol-spacing'); 
        
           }

Tests
Styles

Rename video url to urls. Fixes video source: url ⇢ urls #260
- JS
- Native: no gl-native patch needed: video not supported
- Spec
  
  mapbox-gl-style-spec/reference/v8.json
  
  Line 137 in 2b7c377
  
  "urls": {
- Migration https://github.com/mapbox/mapbox-gl-style-spec/pull/264/files#diff-d94eefc8f1c24000ab9c6b1aa11ed555R34
- Tests
- Styles
ImageSource source type
- JS [needs code review] Add ImageSource for VideoSource-like image sources. mapbox-gl-js#1174
- Native shipping without Support "image" source type mapbox-gl-native#1350
- Spec
- Migration none needed: new feature
- Tests add image source tests mapbox-gl-test-suite#27
- Styles
Flip coordinate order of video coordinates. Fixes Switch to lon, lat order #250
- JS
- Native: no gl-native patch needed: video not supported
- Spec
- Migration
- Tests
- Styles
background-image ⇢ background-pattern, line-image ⇢ line-pattern, fill-image ⇢ fill-pattern to fix Rename *-image properties to *-pattern #215
- JS
- Native v8 Omnibus 2 mapbox-gl-native#993
- Spec
- Migration
- Tests
- Styles
Circle type
- JS V8 circle mapbox-gl-js#1286
- Native Add circle render type mapbox-gl-native#2053
- Spec
- Tests
- Styles
Remove text-max-size and icon-max-size
- JS
- Native
- Spec get rid of text-max-size and icon-max-size #255
- Migration
- Tests
- Styles
Drop constants and color ops Drop constants and color-ops from v8 #308
- JS
- Native
- Spec
- Migration
- Tests
- Styles
Change mapbox:// URL semantics sematics for mapbox:// glyphs urls in v8 #309
- JS
- Native
- Spec
- Migration
- Tests
- Styles
Flip label layer priority order label layer priority order #256
- JS
- Native
- Spec
- Migration
- Tests
- Styles

tmcw · 2015-03-21T16:04:37Z

@lbud @quinnvd one thing I've always kind of wondered about the less-style operations (we used them directly in cartocss) was that

lighten & darken
saturate & desaturate
fadeout & fadein

Are basically duals: saying saturate: 10% means desaturate: -10% and you get the picture. Especially given that we'll be wrapping these in a UI, I think separating the negative and positive versions of the transform will just make downstream implementations weirder.

Thoughts?

lbud · 2015-03-24T01:08:04Z

@tmcw hm, true, and I see how if we use a slider UI centered at neutral this would make the implementation weird. But I also wonder if consistency from a Carto/LESS background is important.
cc @nickidlugash @samanpwbb @edenh — ?

nickidlugash · 2015-03-25T15:27:34Z

@lbud Personally I'm in favor of prioritizing UI implementation over consistency with carto/LESS.

samanpwbb · 2015-03-25T15:56:46Z

@nickidlugash @lbud regardless of how we end up doing this in the style JSON, the UI can do exactly what we want it to do. I was curious about this so I sketched it up:

https://github.com/mapbox/app-styles/issues/1352

Basically: show more fields and assume positive input values, or show less fields and assume both positive and negative input fields. Even if we include all the filters, we can still hide the 'negative' versions of the filters in the UI. I do believe if we implement a UI more like sketch 1, having both positive and negative options available would be better usability:

As a user, I know I want something to be desaturated. I'm going to look for "desaturate" first not for "negative saturate".

tmcw · 2015-03-25T18:20:22Z

samanpwbb · 2015-03-25T18:26:24Z

@tmcw I agree with you here, lets drop the inverse filters. It'll be simpler to implement in the UI.

nickidlugash · 2015-03-25T18:26:45Z

I was thinking sliders, too.

lbud · 2015-03-26T09:10:17Z

Ok, so we'll pick saturate, lighten, and which fade one makes more sense to be positive? (I'm instinctively inclined to say fadein should be positive, although I would guess that's used less frequently…)

samanpwbb · 2015-03-26T15:00:03Z

@lbud how about just 'fade' - positive values increase fade, negative values decrease fade?

tmcw · 2015-04-14T22:18:54Z

Another modification for comment:

I think that we should support embedded sprite metadata: instead of pointing to a URL that contains sprite metadata, that data should be nested under the sprite key of the stylesheet.

jfirebaugh · 2015-04-14T22:27:14Z

embedded sprite metadata

What's the rationale? I'm tentatively 👎 because previous discussions have pointed towards an omnibus format for sprites that combines images and metadata, which would either duplicate or obsolete style-embedded-metadata.

tmcw · 2015-04-14T22:29:18Z

What's the rationale?

One fewer HTTP request to show each map
Easier & faster to do better stylesheet validation - validate that references to the sprite are valid
Simpler to implement in app-styles (okay, showing my hand with that one)
- In our current implementation, to reference a style's sprite, we need to do a three-step process of saving the sprite, getting its id, building the sprite url with the id, and then resaving the style with a correct sprite url

incanus · 2015-04-14T22:51:27Z

Sprite metadata in the style feels bloated.

We already support two pixel ratios, and might do more. Even if we handle SVG sprites, we will always do rasters of some sort and multi-DPI just makes for a messy style section.
To clarify @jfirebaugh's point, we've talked (Treat "images" as nested collection of a style, like sources or layers #220) about a binary sprite storage format to reduce branching and increase performance. Being able to seek a sprite's metadata out of the store without having to pre-parse the whole store from a text format would unblock runtime sprite changes (such as a set of POI icons changing during a label language swap) or sprite attribute changes (such as toggling an icon theme as part of a POI level-of-detail change or a class toggle which affects icon style, such as color change in a night style).
We will invariably keep the imagery itself out of the style (base64 encoding or something similar would be a waste), so why split the imagery and metadata? One less HTTP request doesn't feel like a level trade given the complexity of having imagery and metadata in two places.

If sprites aren't valid in a style, just skip showing them? Easy way to point out a problem.

tmcw · 2015-04-20T18:23:16Z

/cc @mapbox/gl

Can we schedule a v8 sprint directly after the gl-native code is shipped? To ship this, we need many more hands on deck.

tmcw · 2015-04-20T18:53:39Z

Additionally: should we fold #276 Circle render type into this issue? I'm about to sketch out an implementation in gl-js

lbud · 2015-04-29T20:13:25Z

Grabbing types on native.

lbud · 2015-04-29T21:06:49Z

@tmcw should validate.constants also enforce that all constants have types?

tmcw · 2015-04-29T21:13:22Z

y, i'll implement that.

Remove color ops from v8

#255

This happens in mapbox-gl-styles. Doing it here too creates a circular dependency.

Conflicts: CHANGELOG.md package.json

- remove setConstant - add setCenter - add setZoom - add setBearing - add setPitch Issue: #338

'pitch' follows 'center', 'zoom' and 'bearing' to define the default camera position. 0 degrees is perpendicular to the surface. Issue: #341

In new versions of Node and browserify `URL.parse()` URL encodes properties on the resulting object. This has the effect of breaking the migration script in the browser. We can decodeURI the path segments we need to compare in a manner that is backwards and future compatible. Tested with: - browserify - Node 0.10 - IO 3.0

Every other layer type already supports visibility.

Types were made more specific to add extra type safety around constants. Without constants, we no longer need these more specific types. Fewer, well-known types makes tooling support easier. - '*-enum' -> 'enum' - '*-array' -> 'array' - 'opacity' -> 'number' - 'field-template' -> 'string'

Issue: #340

tmcw mentioned this pull request Mar 12, 2015

v8 Spec mapbox/mapbox-gl-js#1081

Closed

9 tasks

lbud mentioned this pull request Mar 26, 2015

Support color operation functions #38

Closed

lbud mentioned this pull request Apr 15, 2015

Color operations, take two mapbox/mapbox-gl-js#1158

Closed

tmcw mentioned this pull request Apr 20, 2015

v8 Omnibus 2 mapbox/mapbox-gl-native#993

Closed

7 tasks

lbud mentioned this pull request Apr 21, 2015

Color operations mapbox/mapbox-gl-native#1311

Closed

3 tasks

This was referenced Apr 27, 2015

Support "image" source type mapbox/mapbox-gl-native#1350

Closed

[wip] V8 mapbox/mapbox-gl-js#1192

Merged

nickidlugash mentioned this pull request May 29, 2015

get rid of text-max-size and icon-max-size #255

Closed

nickidlugash mentioned this pull request Jun 15, 2015

Remove "fill-antialias" property #289

Closed

jfirebaugh force-pushed the v8 branch from 22361cc to 28dde7a Compare June 17, 2015 17:40

Updated docs/_layouts/default.html

6719860

brunoabinader mentioned this pull request Jul 9, 2015

[WIP] circle layer mapbox/mapbox-gl-native#1863

Closed

1 task

Merge pull request #333 from mapbox/v8-remove-ops

5429f9b

Remove color ops from v8

lucaswoj mentioned this pull request Aug 12, 2015

Develop a testing harness for v8 styles #334

Closed

jfirebaugh and others added 4 commits August 12, 2015 11:12

Fix styles pin

7940fa7

get rid of text-max-size, icon-max-size

8555318

#255

Update styles pin

1046778

Added fontstack url migration

87c4620

jfirebaugh mentioned this pull request Aug 12, 2015

[wip] V8 mapbox/mapbox-gl-native#2052

Merged

add label priority migration

d6a0c08

jfirebaugh force-pushed the v8 branch from a7eebe2 to d6a0c08 Compare August 13, 2015 19:00

jfirebaugh added 2 commits August 13, 2015 12:58

Update glyphs URL in docs

8d0ba25

Remove support for pre-v6 styles

1c6d353

jfirebaugh force-pushed the v8 branch from ba700ea to 1c6d353 Compare August 13, 2015 20:12

jfirebaugh and others added 15 commits August 13, 2015 15:11

Update CHANGELOG for v8

6eb0e1b

Remove mapbox-gl-styles validation check

1a53df4

This happens in mapbox-gl-styles. Doing it here too creates a circular dependency.

Merge branch 'mb-pages' into v8

b0e4970

Conflicts: CHANGELOG.md package.json

Added image source type

66cc08c

8.0.1

e860081

Update diff for v8

42a2961

- remove setConstant - add setCenter - add setZoom - add setBearing - add setPitch Issue: #338

Add 'pitch' as a $root property

6923792

'pitch' follows 'center', 'zoom' and 'bearing' to define the default camera position. 0 degrees is perpendicular to the surface. Issue: #341

Add visibility layout property for circles

a8d26dc

Every other layer type already supports visibility.

Remove unused type validators

6c84895

Remove constants from v8 reference schema

eb01ce6

Issue: #340

8.1.0

bbb6ba8

Add sprites URL change to CHANGELOG.md

fe768eb

add text-size and icon-size change to changelog

974558d

jfirebaugh merged commit 974558d into mb-pages Sep 2, 2015

jfirebaugh deleted the v8 branch September 2, 2015 21:57

lucaswoj mentioned this pull request Feb 1, 2017

Remove "fill-antialias" property mapbox/mapbox-gl-js#4093

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v8 Omnibus #264

v8 Omnibus #264

tmcw commented Mar 12, 2015

tmcw commented Mar 21, 2015

lbud commented Mar 24, 2015

nickidlugash commented Mar 25, 2015

samanpwbb commented Mar 25, 2015

tmcw commented Mar 25, 2015

samanpwbb commented Mar 25, 2015

nickidlugash commented Mar 25, 2015

lbud commented Mar 26, 2015

samanpwbb commented Mar 26, 2015

tmcw commented Apr 14, 2015

jfirebaugh commented Apr 14, 2015

tmcw commented Apr 14, 2015

incanus commented Apr 14, 2015

tmcw commented Apr 20, 2015

tmcw commented Apr 20, 2015

lbud commented Apr 29, 2015

lbud commented Apr 29, 2015

tmcw commented Apr 29, 2015

	"text-font": {
	"type": "array",
	"value": "string",
	"function": "piecewise-constant",
	"default": ["Open Sans Regular", "Arial Unicode MS Regular"],
	"doc": "Font stack to use for displaying text.",
	"requires": [
	"text-field"
	]
	},

	eachLayout(layer, function(layout) {
	if (typeof layout['text-font'] === 'string') {
	layout['text-font'] = layout['text-font'].split(',')
	.map(function(s) {
	return s.trim();
	});
	}

	"symbol-spacing": {
	"type": "number",
	"default": 250,
	"minimum": 1,
	"function": "interpolated",
	"units": "pixels",
	"doc": "Minimum distance between two symbol anchors.",
	"requires": [
	{
	"symbol-placement": "line"
	}
	]

	if (layout['symbol-min-distance'] !== undefined) {
	renameProperty(layout, 'symbol-min-distance', 'symbol-spacing');
	}

v8 Omnibus #264

v8 Omnibus #264

Conversation

tmcw commented Mar 12, 2015

tmcw commented Mar 21, 2015

lbud commented Mar 24, 2015

nickidlugash commented Mar 25, 2015

samanpwbb commented Mar 25, 2015

tmcw commented Mar 25, 2015

samanpwbb commented Mar 25, 2015

nickidlugash commented Mar 25, 2015

lbud commented Mar 26, 2015

samanpwbb commented Mar 26, 2015

tmcw commented Apr 14, 2015

jfirebaugh commented Apr 14, 2015

tmcw commented Apr 14, 2015

incanus commented Apr 14, 2015

tmcw commented Apr 20, 2015

tmcw commented Apr 20, 2015

lbud commented Apr 29, 2015

lbud commented Apr 29, 2015

tmcw commented Apr 29, 2015