Skip to content
This repository has been archived by the owner on Apr 10, 2018. It is now read-only.

get rid of text-max-size and icon-max-size #255

Closed
ansis opened this issue Mar 10, 2015 · 10 comments
Closed

get rid of text-max-size and icon-max-size #255

ansis opened this issue Mar 10, 2015 · 10 comments
Assignees
Milestone

Comments

@ansis
Copy link
Contributor

ansis commented Mar 10, 2015

currently
text-max-size is a layout property and is used for label placement
text-size is a paint property is used to change

We should only have one property.

How would we deal with a property that is need both for layout and rendering?

@jfirebaugh
Copy link
Contributor

layout could calculate what the actual maximum text-size is going to be, right?

@mourner
Copy link
Member

mourner commented Mar 10, 2015

Yeah, the only problem is that we introduce a new concept here: a paint property that implicitly affects the layout step as well. But it's probably fine.

@jfirebaugh
Copy link
Contributor

Hrm, yeah, setPaintProperty would then have to special-case text-size to trigger a relayout.

@mourner
Copy link
Member

mourner commented Mar 10, 2015

Or we could have it the other way around — make it a layout property that implicitly creates a paint property.

@jfirebaugh
Copy link
Contributor

It would still need to support interpolated functions, which would be a different special case. But maybe a less problematic one.

ansis added a commit to mapbox/mapbox-gl-native that referenced this issue Apr 24, 2015
This way it matches -js. The real fix will eventually be
mapbox/mapbox-gl-style-spec#255
@nickidlugash
Copy link
Contributor

@jfirebaugh @mourner @ansis any consensus on what we should do here?

@tmcw tmcw mentioned this issue May 29, 2015
82 tasks
@nickidlugash
Copy link
Contributor

I added this to v8 omnibus.

@nickidlugash
Copy link
Contributor

We should also get rid of icon-max-size. I've added that to this ticket name, and will add to v8.

@nickidlugash nickidlugash changed the title get rid of text-max-size get rid of text-max-size and icon-max-size Jun 12, 2015
@jfirebaugh jfirebaugh added this to the v8 milestone Aug 6, 2015
@jfirebaugh
Copy link
Contributor

@ansis, can you look into this when you get back?

ansis added a commit that referenced this issue Aug 11, 2015
ansis added a commit to mapbox/mapbox-gl-test-suite that referenced this issue Aug 11, 2015
ansis added a commit to mapbox/mapbox-gl-js that referenced this issue Aug 11, 2015
and make text-size, icon-size layout properties

fixes mapbox/mapbox-gl-style-spec#255
@ansis
Copy link
Contributor Author

ansis commented Aug 11, 2015

pull request for -js: mapbox/mapbox-gl-js#1419

Is the rest of v8 implemented in -native?

ansis added a commit that referenced this issue Aug 12, 2015
ansis added a commit to mapbox/mapbox-gl-test-suite that referenced this issue Aug 12, 2015
ansis added a commit to mapbox/mapbox-gl-js that referenced this issue Aug 12, 2015
and make text-size, icon-size layout properties

fixes mapbox/mapbox-gl-style-spec#255
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants