-
Notifications
You must be signed in to change notification settings - Fork 38
get rid of text-max-size
and icon-max-size
#255
Comments
layout could calculate what the actual maximum |
Yeah, the only problem is that we introduce a new concept here: a paint property that implicitly affects the layout step as well. But it's probably fine. |
Hrm, yeah, |
Or we could have it the other way around — make it a layout property that implicitly creates a paint property. |
It would still need to support interpolated functions, which would be a different special case. But maybe a less problematic one. |
This way it matches -js. The real fix will eventually be mapbox/mapbox-gl-style-spec#255
@jfirebaugh @mourner @ansis any consensus on what we should do here? |
I added this to v8 omnibus. |
We should also get rid of |
text-max-size
text-max-size
and icon-max-size
@ansis, can you look into this when you get back? |
and make text-size, icon-size layout properties fixes mapbox/mapbox-gl-style-spec#255
pull request for -js: mapbox/mapbox-gl-js#1419 Is the rest of v8 implemented in -native? |
and make text-size, icon-size layout properties fixes mapbox/mapbox-gl-style-spec#255
currently
text-max-size
is a layout property and is used for label placementtext-size
is a paint property is used to changeWe should only have one property.
How would we deal with a property that is need both for layout and rendering?
The text was updated successfully, but these errors were encountered: