-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add ability to disable overdraw shaders #5555
Conversation
Disabling overdraw implies in actually disabling debug options in general - 👍 for including https://github.com/mapbox/mapbox-gl-native/blob/master/include/mbgl/map/map.hpp#L171-L174 inside those ifdefs? |
Moved discussion about debug options in release mode to #5699. |
Node render test |
efbb046
to
6916c91
Compare
@brunoabinader 👍 to |
a3c90ab
to
001f472
Compare
@1ec5 @mikemorris could you please 👀 on the changelog changes before 🚢 ? |
@@ -6,6 +6,8 @@ Mapbox welcomes participation and contributions from everyone. Please read [CON | |||
|
|||
* Added [quadkey](https://msdn.microsoft.com/en-us/library/bb259689.aspx) support and limited WMS support in raster tile URL templates. ([#5628](https://github.com/mapbox/mapbox-gl-native/pull/5628)) | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: remove this blank line.
For iOS and macOS, can you mark the enum values with If you think it's still useful to have these options in iosapp, you can conditionally compile the code that adds and carries out the action. For macosapp, change the menu item's validation code to conditionally return YES for debug and NO otherwise. |
If deprecation and conditional compiling is too much trouble, it'd be fine to simply document the two enum options as being nonfunctional. |
5e1bcc4
to
81852dc
Compare
81852dc
to
000539a
Compare
#5371 and #5534 add a second set of shaders for overdraw mode. We should completely disable this with
ifdefs
or so when we're building a release build for publication to avoid additional shader compilation overhead. Overdraw mode is a debugging tool and shouldn't be in the SDK./cc @brunoabinader