This repository has been archived by the owner on Aug 8, 2023. It is now read-only.
Break lines on commonly unspaced punctuation #2598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Love everything about this. |
|
Awesome 👍 |
|
This is great @1ec5 👍 |
|
👏 |
Particularly hyphens and soft hyphens. Fixes #2595.
1ec5
force-pushed
the
1ec5-taumatawhakatangihangakoauauotamateaturipukakapikimaungahoronukupokaiwhenuakitanatahu-2595
branch
from
488a220
to
5979994
Compare
1ec5
deleted the
1ec5-taumatawhakatangihangakoauauotamateaturipukakapikimaungahoronukupokaiwhenuakitanatahu-2595
branch
|
Flagging a minor issue with this - different languages have different conventions for wrapping on a hyphen. This came up previously in the Mapnik project. I'm not sure what's needed to support multiple wrapping styles - seems like it would have to be an option & implemented in the gl-style-spec? |
|
Yes, this PR is but a stopgap for a very common case. Languages have different conventions for wrapping on spaces, too, but we currently ignore those conventions for simplicity’s sake. Employing Harbuzz would address a number of other text wrapping issues like #1223 that we aren’t prepared to think about quite yet. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks lines in labels on commonly unspaced punctuation, particularly hyphens (important in French-speaking regions) and soft hyphens (important in Welsh, Thai, and Māori-speaking regions).
Before:
After:
Stress test:
Fixes #2595.
/cc @ansis @nickidlugash @mikemorris @peterqliu