Break lines on commonly unspaced punctuation #1617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Particularly hyphens and soft hyphens. Fixes #1115.
|
Love this, looks good to me. |
1ec5
deleted the
1ec5-taumatawhakatangihangakoauauotamateaturipukakapikimaungahoronukupokaiwhenuakitanatahu-1115
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR breaks lines in labels on commonly unspaced punctuation, particularly hyphens (important in French-speaking regions) and soft hyphens (important in Welsh, Thai, and Māori-speaking regions). The improved wrapping also seems to fix quite a few label collisions.
Before:
After:
This is a port of mapbox/mapbox-gl-native#2598 that fixes #1115.
/cc @peterqliu