Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove icon from text-font/chinese test so that it passes everywhere #4658

Merged
merged 1 commit into from
Apr 28, 2017
Merged

Remove icon from text-font/chinese test so that it passes everywhere #4658

merged 1 commit into from
Apr 28, 2017

Conversation

jfirebaugh
Copy link
Contributor

The icons have been problematic -- see #4539 -- and this test was still failing for me and others when run locally.

ChrisLoer
ChrisLoer approved these changes Apr 28, 2017
View reviewed changes
Copy link
Contributor

@ChrisLoer ChrisLoer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray, problem solved? I profess no understanding of what was going on here.

@jfirebaugh jfirebaugh merged commit ad0bcfe into master Apr 28, 2017
@jfirebaugh jfirebaugh deleted the text-font-chinese branch April 28, 2017 18:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChrisLoer ChrisLoer ChrisLoer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfirebaugh @ChrisLoer