Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn Incident.Impact type into an enumeration #519

Merged
merged 4 commits into from
Feb 18, 2021
Merged

Turn Incident.Impact type into an enumeration #519

merged 4 commits into from
Feb 18, 2021

Conversation

dersim-davaod
Copy link
Contributor

Resolves: #518

@dersim-davaod dersim-davaod added op-ex Refactoring, Tech Debt or any other operational excellence work. release blocker iOS labels Feb 18, 2021
@dersim-davaod dersim-davaod self-assigned this Feb 18, 2021
@1ec5 1ec5 added this to the v2.0.0 milestone Feb 18, 2021
@1ec5 1ec5 added backwards incompatible changes that break backwards compatibility of public API and removed iOS labels Feb 18, 2021
1ec5
1ec5 approved these changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@1ec5 1ec5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested changelog entry:

  • The Incident.impact property is now an Incident.Impact value instead of a string. (#519)

@1ec5 1ec5 changed the base branch from main to release-v2.0 February 18, 2021 16:04
@1ec5 1ec5 merged commit 9af4ddd into release-v2.0 Feb 18, 2021
@1ec5 1ec5 deleted the 518-incident-impact-should-be-an-enumeration branch February 18, 2021 20:44
@1ec5 1ec5 mentioned this pull request Feb 22, 2021
Closed
@truburt truburt modified the milestones: v2.0.0, v2.0.0 (Public Preview) Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@1ec5 1ec5 1ec5 approved these changes

Assignees

@dersim-davaod dersim-davaod

Labels
backwards incompatible changes that break backwards compatibility of public API op-ex Refactoring, Tech Debt or any other operational excellence work. release blocker
Projects
None yet
Milestone
v2.0.0 (Public Preview)
Development

Successfully merging this pull request may close these issues.

Incident impact should be an enumeration
3 participants
@dersim-davaod @1ec5 @truburt