Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incident impact should be an enumeration #518

Closed
1ec5 opened this issue Feb 17, 2021 · 2 comments · Fixed by #519
Closed

Incident impact should be an enumeration #518

1ec5 opened this issue Feb 17, 2021 · 2 comments · Fixed by #519
Assignees
@dersim-davaod
Labels
backwards incompatible changes that break backwards compatibility of public API op-ex Refactoring, Tech Debt or any other operational excellence work. release blocker
Milestone
v2.0.0 (Public Pr...

Comments

@1ec5
Copy link
Contributor

1ec5 commented Feb 17, 2021

Incident.impact is currently decoded as a string, but this documentation states that the impact may only be one of five values, so it should be decoded as an enumeration instead.

/ref #482
/cc @mapbox/navigation-ios
@1ec5 1ec5 added backwards incompatible changes that break backwards compatibility of public API op-ex Refactoring, Tech Debt or any other operational excellence work. labels Feb 17, 2021
@1ec5 1ec5 added this to the v2.0.0 milestone Feb 17, 2021
@1ec5
Copy link
Contributor Author

1ec5 commented Feb 17, 2021

Marking as a release blocker, because we’re about to introduce some fragile code in the navigation SDK that converts between strings and enumerations in MapboxNavigationNative that would benefit from a more type-safe representation.

@dersim-davaod dersim-davaod self-assigned this Feb 18, 2021
@dersim-davaod dersim-davaod mentioned this issue Feb 18, 2021
Merged
@1ec5
Copy link
Contributor Author

1ec5 commented Feb 22, 2021 •
edited
Loading

Fixed in #519 on the release-v2.0 branch for v2.0.0-alpha.1.

@1ec5 1ec5 closed this as completed Feb 22, 2021
@truburt truburt modified the milestones: v2.0.0, v2.0.0 (Public Preview) Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dersim-davaod dersim-davaod

Labels
backwards incompatible changes that break backwards compatibility of public API op-ex Refactoring, Tech Debt or any other operational excellence work. release blocker
Projects
None yet
Milestone
v2.0.0 (Public Preview)
Development

Successfully merging a pull request may close this issue.

Turn Incident.Impact type into an enumeration mapbox/mapbox-directions-swift
3 participants
@1ec5 @dersim-davaod @truburt