-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Road position services #19
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Creates MaliputQueryNode as a ROS2 proxy to make RoadNetwork queries. - Provides a sample configuration file use maliput_malidrive. Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
- Moves specifc service request tests to individual files. - Creates a function to make a service request and return the result. Signed-off-by: Agustin Alba Chicar <[email protected]>
22 tasks
francocipollone
previously approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Signed-off-by: Agustin Alba Chicar <[email protected]>
agalbachicar
force-pushed
the
agalbachicar/#1_road_position_services
branch
from
January 17, 2023 09:48
3c468aa
to
fb05a86
Compare
francocipollone
approved these changes
Jan 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 New feature
Part of #1
Goes on top of #18
Summary
Adds
/to_road_position
and/find_road_positions
to convert INERTIAL Frame to LANE Frame coordinates.Test it
Via unit tests.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.