Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Road position services #19

Merged
merged 21 commits into from
Jan 17, 2023
Merged

Conversation

agalbachicar
Copy link
Collaborator

🎉 New feature

Part of #1
Goes on top of #18

Summary

Adds /to_road_position and /find_road_positions to convert INERTIAL Frame to LANE Frame coordinates.

Test it

Via unit tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

- Creates MaliputQueryNode as a ROS2 proxy to make RoadNetwork queries.
- Provides a sample configuration file use maliput_malidrive.

Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
Signed-off-by: Agustin Alba Chicar <[email protected]>
- Moves specifc service request tests to individual files.
- Creates a function to make a service request and return the result.

Signed-off-by: Agustin Alba Chicar <[email protected]>
Copy link
Contributor

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@agalbachicar agalbachicar merged commit c5760d0 into main Jan 17, 2023
@agalbachicar agalbachicar deleted the agalbachicar/#1_road_position_services branch January 17, 2023 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants