Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bazel] Guarantee shared library creation for the plugin #269

Merged
merged 2 commits into from
Jan 10, 2024
Merged

[bazel] Guarantee shared library creation for the plugin #269

merged 2 commits into from
Jan 10, 2024

Conversation

francocipollone
Copy link
Collaborator

🦟 Bug fix

Summary

  • What the title says.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone
Some fixes to plugin target.
8afaad2 
Signed-off-by: Franco Cipollone <[email protected]>
@francocipollone
Use linkstatic in false
098d2dd 
Signed-off-by: Franco Cipollone <[email protected]>
@francocipollone francocipollone mentioned this pull request Jan 8, 2024
Merged
6 tasks
@francocipollone francocipollone mentioned this pull request Jan 9, 2024
Closed
3 tasks
agalbachicar
agalbachicar approved these changes Jan 10, 2024
View reviewed changes
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agalbachicar agalbachicar merged commit db60370 into maliput:main Jan 10, 2024
5 checks passed
@francocipollone francocipollone deleted the francocipollone/rust_bazel_plugin_lib branch February 2, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agalbachicar agalbachicar agalbachicar approved these changes

@stonier stonier Awaiting requested review from stonier

Assignees
No one assigned
Labels
None yet
Projects
Maliput - Core development
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@francocipollone @agalbachicar