Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rely on BCR for bringing maliput_malidrive #8

Closed
3 tasks
francocipollone opened this issue Jan 9, 2024 · 0 comments · Fixed by #10
Closed
3 tasks

Rely on BCR for bringing maliput_malidrive #8

francocipollone opened this issue Jan 9, 2024 · 0 comments · Fixed by #10
Labels
enhancement New feature or request maliput-sdk

Comments

@francocipollone
Copy link
Contributor

Summary

At the moment that #7 was created maliput_malidrive hadn't been part of the BCR so we had to use submodules

// TODO(francocipollone): Remove this custom build once maliput_malidrive is within BCR.
env::set_current_dir("maliput_malidrive")
.unwrap_or_else(|_| panic!("Unable to change directory to {}", "maliput_malidrive"));
let build_malidrive = std::process::Command::new("bazel")
.arg("build")
.arg("//...")
.status()
.expect("Failed to generate build script");
if build_malidrive.code() != Some(0) {
panic!("Failed to generate build script");
}

Requisites:

Tasks:

  • Add maliput_malidrive to MODULE.bazel file
  • Remove maliput_malidrive submodule
  • Remove custom build of maliput_malidrive in build.rs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request maliput-sdk
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant