-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relies on BCR for maliput_malidrive binaries. #10
Conversation
❗ CI will fail until bazelbuild/bazel-central-registry#1423 is merged |
@francocipollone can you please take a look at bazelbuild/bazel-central-registry#1423, two presubmit checks failed. I think we are missing a few formalities there. |
Changes here LGTM btw. |
This is the log and I was expecting a BCR maintainer to inform us if anything is missing. |
I guess the text in that log is pertinent, thanks for finding that.
This is the thing we need to update: https://github.com/maliput/maliput_malidrive/blob/main/.bcr/presubmit.yml Let's see if the BCR Github App makes a new release if we patch that. Or we could just tag a new patch release. |
|
Signed-off-by: Franco Cipollone <[email protected]>
2caf015
to
00da5fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
🎉 New feature
Closes #8
Requisites
Summary
Test it
Checklist