Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relies on BCR for maliput_malidrive binaries. #10

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

francocipollone
Copy link
Contributor

🎉 New feature

Closes #8

Requisites

Summary

  • Relies on maliput_malidrive in BCR -> 0.2.1 version

Test it

cargo run --example create_rn

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

@francocipollone
Copy link
Contributor Author

❗ CI will fail until bazelbuild/bazel-central-registry#1423 is merged

@agalbachicar
Copy link
Contributor

@francocipollone can you please take a look at bazelbuild/bazel-central-registry#1423, two presubmit checks failed. I think we are missing a few formalities there.

@agalbachicar
Copy link
Contributor

Changes here LGTM btw.

@francocipollone
Copy link
Contributor Author

@francocipollone can you please take a look at bazelbuild/bazel-central-registry#1423, two presubmit checks failed. I think we are missing a few formalities there.

image
https://buildkite.com/bazel/bcr-presubmit/builds/3456#018d6ba5-7ba7-46ea-a71e-b8e89d46e6ff

This is the log and I was expecting a BCR maintainer to inform us if anything is missing.
Pinging @stonier as BCR savvy here 😃 . Do you have extra info in case we are missing something here?

@stonier
Copy link

stonier commented Feb 15, 2024

Pinging @stonier as BCR savvy here 😃 . Do you have extra info in case we are missing something here?

I guess the text in that log is pertinent, thanks for finding that.

  1. It explains why it's waiting on a BCR maintainer to process the PR
  2. We should work out how to put the bazel version into that yaml (must be new)

This is the thing we need to update: https://github.com/maliput/maliput_malidrive/blob/main/.bcr/presubmit.yml

Let's see if the BCR Github App makes a new release if we patch that. Or we could just tag a new patch release.

@francocipollone
Copy link
Contributor Author

Copy link
Contributor

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit b0bce1c into main Feb 26, 2024
2 checks passed
@francocipollone francocipollone deleted the francocipollone/use_malidrive_bcr branch February 26, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rely on BCR for bringing maliput_malidrive
3 participants