Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for the DistanceRouter using Segments #83

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

agalbachicar
Copy link
Collaborator

@agalbachicar agalbachicar commented Jun 28, 2024

🎉 New feature

Goes on top of #81
Pairs with maliput/maliput#636

Summary

Fixes tests to account for the use api::Segments in the DistanceRouter.

Test it

By running the tests.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if it affects the public API)

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@agalbachicar
Copy link
Collaborator Author

I'll target main once the parent PR is merged.

francocipollone
francocipollone previously approved these changes Jul 5, 2024
Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@liangfok liangfok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but the commit message seems off:

Fix DistanceRouter to account for the use of Segments to route.

Should this be "Fix DistanceRouter test"?

@agalbachicar agalbachicar force-pushed the agalbachicar/#543_router_uses_segments branch from 8de723d to e973950 Compare October 1, 2024 08:08
@agalbachicar
Copy link
Collaborator Author

I've just updated the commit message and the history in this branch to account for changes in the parent branch.

liangfok
liangfok previously approved these changes Oct 5, 2024
Copy link
Collaborator

@liangfok liangfok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Base automatically changed from agalbachicar/#543_route_end_to_end_connectivity to main October 8, 2024 17:40
@agalbachicar agalbachicar dismissed stale reviews from liangfok and francocipollone October 8, 2024 17:40

The base branch was changed.

@agalbachicar agalbachicar merged commit 14aafc5 into main Oct 9, 2024
3 checks passed
@agalbachicar agalbachicar deleted the agalbachicar/#543_router_uses_segments branch October 9, 2024 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants