-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests for the DistanceRouter using Segments #83
Conversation
I'll target main once the parent PR is merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but the commit message seems off:
Fix DistanceRouter to account for the use of Segments to route.
Should this be "Fix DistanceRouter test"?
8de723d
to
e973950
Compare
I've just updated the commit message and the history in this branch to account for changes in the parent branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The base branch was changed.
Signed-off-by: Agustin Alba Chicar <[email protected]>
e973950
to
f2fb746
Compare
🎉 New feature
Goes on top of #81
Pairs with maliput/maliput#636
Summary
Fixes tests to account for the use api::Segments in the DistanceRouter.
Test it
By running the tests.
Checklist
Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.