Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable doxygen verification. #56

Merged
merged 1 commit into from
Sep 7, 2021

Conversation

francocipollone
Copy link
Collaborator

@francocipollone francocipollone commented Sep 1, 2021

Pairs with ToyotaResearchInstitute/ament_cmake_doxygen#6
Related to maliput/maliput_infrastructure#227

One doxygen warning :

test 2
    Start 2: maliput_dragway_doxygen_warnings

2: Test command: /bin/bash "/home/franco/maliput_ws/install/ament_cmake_doxygen/share/ament_cmake_doxygen/cmake/../tools/check_doc_warns.sh" "/home/franco/maliput_ws/build/maliput_dragway/ament_cmake_doxygen/maliput_dragway/warnings.log"
2: Test timeout computed to be: 9.99988e+06
2: Error. The following warnings were found in /home/franco/maliput_ws/build/maliput_dragway/ament_cmake_doxygen/maliput_dragway/warnings.log.
2: /home/franco/maliput_ws/src/maliput_dragway/include/maliput_dragway/road_geometry.h:52: warning: The following parameters of maliput::dragway::RoadGeometry::RoadGeometry(const api::RoadGeometryId &id, int num_lanes, double length, double lane_width, double shoulder_width, double maximum_height, double linear_tolerance, double angular_tolerance, const math::Vector3 &inertial_to_backend_frame_translation) are not documented:
2:   parameter 'inertial_to_backend_frame_translation'
2/5 Test #2: maliput_dragway_doxygen_warnings ...***Failed    0.00 sec

@francocipollone francocipollone force-pushed the francocipollone/check_doxygen_warns branch from 2d29eb5 to 0b74915 Compare September 2, 2021 13:09
Copy link
Collaborator

@agalbachicar agalbachicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@francocipollone francocipollone merged commit f0cd043 into main Sep 7, 2021
@francocipollone francocipollone deleted the francocipollone/check_doxygen_warns branch September 7, 2021 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants