Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try to checkout same branch in dependencies #328

Merged
merged 1 commit into from
Nov 30, 2020

Conversation

scpeters
Copy link
Contributor

This is a port of the branch checkout behavior from maliput/maliput_dragway#18. I've tested it with the eloquent branch that naively attempts to use eloquent in dfd57a0 but fails due to missing fixes from maliput/maliput#370 and maliput/maliput_dragway#20. Since those are also on eloquent branches in their respective repositories, adding the branch checkout behavior to the actions CI in 642ff22 allows the eloquent branch to pass CI.

Original description of branch checkout behavior

This implements some behavior from our Jenkins CI that
attempts to checkout a branch of the same name in all
dependency packages. This requires setting fetch-depth: 0
in the actions/checkout steps and installing git 2.18+
before those checkout steps. For 18.04, the git-core ppa
is used; this will not be needed on 20.04.

This implements some behavior from our Jenkins CI that
attemps to checkout a branch of the same name in all
dependency packages. This requires setting `fetch-depth: 0`
in the actions/checkout steps and installing git 2.18+
before those checkout steps. For 18.04, the git-core ppa
is used; this will not be needed on 20.04.
@scpeters
Copy link
Contributor Author

this is related to maliput/maliput_infrastructure#136 (comment)

Copy link
Collaborator

@francocipollone francocipollone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@scpeters scpeters merged commit 2a8c70a into master Nov 30, 2020
@scpeters scpeters deleted the scpeters/try_checkout_same_branch branch November 30, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants